-
Notifications
You must be signed in to change notification settings - Fork 47
Refactor on TaskSet and Buffer
#34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pan-x-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the inline comments
…nd rename `raw_data_path` to `source_data_path`
yanxi-chen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the inline comments.
|
/run-unittest |
Summary
Failed TestsNo failed tests ✨ Flaky TestsNo flaky tests ✨ SkippedNo skipped tests ✨ Tests
Github Test Reporter by CTRF 💚 |
pan-x-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the line comments, others LGTM
pan-x-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
TaskSetandBuffer.trinity/trainer/verl/fsdp_workers.py.Checklist
Please check the following items before code is ready to be reviewed.