Skip to content

Refactor on TaskSet and Buffer #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pan-x-c merged 15 commits into from
May 15, 2025
Merged

Refactor on TaskSet and Buffer #34

pan-x-c merged 15 commits into from
May 15, 2025

Conversation

@chenyushuo
Copy link
Collaborator

@chenyushuo chenyushuo commented May 12, 2025 •
edited
Loading

Description

  1. Refactor on TaskSet and Buffer.
  2. Bug fix in trinity/trainer/verl/fsdp_workers.py.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

pan-x-c
pan-x-c reviewed May 14, 2025
View reviewed changes
Copy link
Collaborator

@pan-x-c pan-x-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the inline comments

@chenyushuo
refactor on config_manager.py; rename format_config to format a…
0a967ab 
…nd rename `raw_data_path` to `source_data_path`
pan-x-c
pan-x-c reviewed May 14, 2025
View reviewed changes
yanxi-chen
yanxi-chen reviewed May 15, 2025
View reviewed changes
Copy link
Collaborator

@yanxi-chen yanxi-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the inline comments.

yanxi-chen
yanxi-chen reviewed May 15, 2025
View reviewed changes
@chenyushuo
Copy link
Collaborator Author

chenyushuo commented May 15, 2025

/run-unittest

@github-actions
Copy link

github-actions bot commented May 15, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
22 22 0 0 0 0 0 712ms

Failed Tests

No failed tests ✨

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name Status Flaky Duration
tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer ✅ 3ms
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer ✅ 1ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid ✅ 1ms
tests/common/config_test.py::TestConfig::test_load_default_config ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion ✅ 1ms
tests/common/vllm_test.py::TestModelWrapperSyncV0::test_generate ✅ 44ms
tests/common/vllm_test.py::TestModelWrapperAsyncV0::test_generate ✅ 42ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV0::test_generate ✅ 51ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV1::test_generate ✅ 57ms
tests/common/vllm_test.py::TestModelWrapperAsyncV1::test_generate ✅ 39ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask ✅ 1ms
tests/explorer/explorer_test.py::BaseExplorerCase::test_explorer ✅ 1ms
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer ✅ 122ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer ✅ 147ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool ✅ 18ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow ✅ 1ms
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer ✅ 1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer ✅ 178ms

Github Test Reporter by CTRF 💚

pan-x-c
pan-x-c reviewed May 15, 2025
View reviewed changes
Copy link
Collaborator

@pan-x-c pan-x-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the line comments, others LGTM

hiyuchang
hiyuchang reviewed May 15, 2025
View reviewed changes
hiyuchang
hiyuchang reviewed May 15, 2025
View reviewed changes
hiyuchang
hiyuchang reviewed May 15, 2025
View reviewed changes
@chenyushuo chenyushuo changed the title Refactor on TaskSet Refactor on TaskSet and Buffer May 15, 2025
pan-x-c
pan-x-c approved these changes May 15, 2025
View reviewed changes
Copy link
Collaborator

@pan-x-c pan-x-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pan-x-c pan-x-c merged commit 2086bec into modelscope:main May 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hiyuchang hiyuchang hiyuchang left review comments

@yanxi-chen yanxi-chen yanxi-chen left review comments

@pan-x-c pan-x-c pan-x-c approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chenyushuo @pan-x-c @hiyuchang @yanxi-chen