Skip to content

Conversation

@HYLcool
Copy link
Collaborator

@HYLcool HYLcool commented Nov 14, 2025

Description

  • move imports of plugins into the methods
  • replace the properties of workflows with assignments

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

* replace the properties of workflows with assignments
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @HYLcool, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the BOTS example code by optimizing how plugins are imported and streamlining the handling of workflow-related properties. The changes aim to improve code organization and efficiency by deferring imports until they are needed and converting property access into direct assignments for workflow attributes.

Highlights

  • Dynamic Imports: Plugin imports (compute_score, BOTSMathBoxedRewardFn) are now moved from the module's top level into the methods where they are actually used (__call__ and reset respectively). This defers import time and can prevent circular dependencies or unnecessary imports.
  • Workflow Property Refactoring: The task_desc and truth attributes in BOTSMathBoxedWorkflow are no longer defined as @property methods. Instead, their values are directly assigned within the reset method, simplifying access and potentially improving performance by avoiding repeated method calls.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the BOTS example code by moving plugin imports into methods and replacing properties with instance variable assignments. While moving imports can be a valid strategy for plugins, the new absolute import paths for bots_reward and bots_math_boxed_reward seem incorrect given the file structure, which could lead to runtime errors. I've left specific comments with suggestions to fix these potential import issues. The change from properties to instance variables is a good improvement for performance and code clarity.

@HYLcool HYLcool merged commit 23e9d55 into modelscope:main Nov 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants