Skip to content

Conversation

@hiyuchang
Copy link
Collaborator

@hiyuchang hiyuchang commented Dec 8, 2025

Description

As the title says.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hiyuchang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new documentation page that serves as a migration guide for users transitioning from the veRL framework to Trinity-RFT. The guide provides detailed parameter mappings and practical examples to facilitate a smooth transition for existing veRL configurations to the Trinity-RFT system, ensuring users can adapt their training setups effectively.

Highlights

  • New Migration Guide: A comprehensive guide has been added to assist users in migrating configurations from the veRL framework to Trinity-RFT.
  • Detailed Parameter Mapping: The guide provides detailed mapping tables for various parameter categories, including algorithm, data, actor/rollout/critic, reward_model, and trainer, showing their equivalents in Trinity-RFT.
  • Practical Training Examples: Concrete examples for PPO and GRPO training are included, illustrating how veRL bash script configurations translate into Trinity-RFT YAML configurations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new documentation file for migrating from veRL to Trinity-RFT. The document is well-structured and provides useful parameter mappings and examples. However, I've found several typos, grammatical errors, and formatting issues that should be addressed to improve clarity. More importantly, there is a significant inconsistency in the PPO training example concerning the buffer.batch_size parameter, which contradicts the explanation provided in the same document and the other example. Correcting these issues will greatly improve the quality and usability of this migration guide.

@hiyuchang hiyuchang changed the title [Doc] Migrate from verl [Doc] Align with verl Dec 9, 2025
@pan-x-c pan-x-c merged commit dd5136a into modelscope:main Dec 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants