Skip to content

Conversation

@chenyushuo
Copy link
Collaborator

Description

  1. Remove base_model in docs.
  2. Add compute_score for learn_to_ask.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

2. Add `compute_score` for `learn_to_ask`.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chenyushuo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the learn_to_ask and tinker examples. It simplifies the Tinker backend configuration by removing an unnecessary base_model parameter from both English and Chinese documentation and example YAML files. Additionally, it enhances the learn_to_ask example by introducing a compute_score function to provide more comprehensive evaluation metrics, alongside refactoring prompt loading for better modularity.

Highlights

  • Tinker Configuration Simplification: The base_model parameter has been removed from Tinker backend configuration examples and documentation, streamlining its setup.
  • Learn2Ask Evaluation Enhancement: A new compute_score function has been added to the learn_to_ask example, providing detailed evaluation metrics for proactive LLM training.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily cleans up the tinker example by removing an obsolete base_model parameter from documentation and configurations, which is a good improvement. It also enhances the learn_to_ask example by adding a compute_score function for evaluation. My review focuses on the new Python code. I've identified a high-severity issue that could lead to a ZeroDivisionError in the new scoring function and provided a suggestion to fix it. I also pointed out an opportunity to refactor some duplicated code to improve maintainability. The documentation changes are clear and correct.

@pan-x-c pan-x-c merged commit 07302f2 into modelscope:main Jan 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants