-
Notifications
You must be signed in to change notification settings - Fork 47
[Doc] Update docker install guide #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @pan-x-c, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly updates the Trinity-RFT installation documentation in both English and Chinese. The primary goal is to improve clarity and guidance for users, particularly by enhancing the Docker installation process. The changes introduce explicit recommendations for different installation methods based on user experience and provide a more comprehensive, step-by-step guide for utilizing the pre-built Docker image, ensuring a smoother setup experience for new users. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the installation documentation, focusing on improving the Docker installation guide in both English and Chinese. The changes successfully restructure the content to be more user-friendly by recommending installation paths based on experience. However, I've identified a couple of critical issues in the new Docker instructions: the docker run command uses an incorrect image name, and the instructions for activating the virtual environment are misleading. Additionally, there are some minor punctuation inconsistencies in the Chinese documentation. I've provided specific suggestions to address these points to ensure the documentation is accurate and clear for users.
Description
As the title says
Checklist
Please check the following items before code is ready to be reviewed.