-
Notifications
You must be signed in to change notification settings - Fork 47
Refactor MathWorkflows #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor MathWorkflows #60
Conversation
|
/run-unittest |
Summary
Failed TestsNo failed tests ✨ Flaky TestsNo flaky tests ✨ SkippedNo skipped tests ✨ Tests
Github Test Reporter by CTRF 💚 |
| ) | ||
|
|
||
| def reset(self, task: Task): | ||
| if task.format_args.system_prompt is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The system_prompt here is a bit confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is basically the same as the old MathWorkflow. Any recommendation on how to improve it?
| self, | ||
| model: ModelWrapper, | ||
| task: Task, | ||
| auxiliary_models: Optional[List[openai.OpenAI]] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a workflow_args: Dict field to the __init__ method of Workflow interface
Description
As the title says.
This PR also enable training using base model, as the added
BaseModelWorkflowshows.Checklist
Please check the following items before code is ready to be reviewed.