Add Sample Strategy #78

pan-x-c · 2025-06-11T12:58:09Z

Description

As the title says

Checklist

Please check the following items before code is ready to be reviewed.

Code has passed all tests
Docstrings have been added/updated in Google Style
Documentation has been updated
Code is ready for review

pan-x-c · 2025-06-11T12:59:15Z

/run-unittest

github-actions · 2025-06-11T13:17:15Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Pending ⏳	Other ❓	Flaky 🍂	Duration ⏱️
29	29	0	0	0	0	0	1.0s

Failed Tests

No failed tests ✨

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name	Status	Duration
tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer	✅	4ms
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer	✅	2ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid	✅	1ms
tests/common/config_test.py::TestConfig::test_load_default_config	✅	6ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion	✅	1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion	✅	1ms
tests/common/vllm_test.py::TestModelWrapperSyncV0::test_generate	✅	45ms
tests/common/vllm_test.py::TestModelWrapperAsyncV0::test_generate	✅	43ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV0::test_generate	✅	52ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV1::test_generate	✅	53ms
tests/common/vllm_test.py::TestModelWrapperAsyncV1::test_generate	✅	39ms
tests/common/vllm_test.py::TestAPIServer::test_api	✅	22ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask	✅	1ms
tests/explorer/explorer_test.py::BaseExplorerCase::test_explorer	✅	1ms
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer	✅	123ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer	✅	150ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool	✅	20ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool_with_auxiliary_models	✅	3ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_workflow_resettable	✅	1ms
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer	✅	1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer	✅	284ms
tests/trainer/trainer_test.py::TestTrainerGSM8K::test_trainer	✅	59ms
tests/trainer/trainer_test.py::TestTrainerGSM8KWithSFT::test_trainer	✅	64ms
tests/trainer/trainer_test.py::TestTrainerDPO::test_trainer	✅	55ms
tests/utils/plugin_test.py::TestPluginLoader::test_load_plugins	✅	4ms

Github Test Reporter by CTRF 💚

trinity/algorithm/sample_strategy/sample_strategy.py

yanxi-chen

lgtm

pan-x-c · 2025-06-12T06:33:52Z

/run-unittest

github-actions · 2025-06-12T06:52:16Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Pending ⏳	Other ❓	Flaky 🍂	Duration ⏱️
29	28	1	0	0	0	0	1.1s

Failed Tests

Failed Tests ❌	Fail Message
❌ tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer	The test failed in the call phase due to an assertion error

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name	Status	Duration
tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer	✅	5ms
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer	✅	3ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid	✅	1ms
tests/common/config_test.py::TestConfig::test_load_default_config	✅	5ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion	✅	1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion	✅	1ms
tests/common/vllm_test.py::TestModelWrapperSyncV0::test_generate	✅	45ms
tests/common/vllm_test.py::TestModelWrapperAsyncV0::test_generate	✅	43ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV0::test_generate	✅	52ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV1::test_generate	✅	52ms
tests/common/vllm_test.py::TestModelWrapperAsyncV1::test_generate	✅	38ms
tests/common/vllm_test.py::TestAPIServer::test_api	✅	21ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask	✅	1ms
tests/explorer/explorer_test.py::BaseExplorerCase::test_explorer	✅	1ms
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer	✅	123ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer	✅	141ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool	✅	23ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool_with_auxiliary_models	✅	4ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_workflow_resettable	✅	1ms
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer	✅	1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer	❌	314ms
tests/trainer/trainer_test.py::TestTrainerGSM8K::test_trainer	✅	62ms
tests/trainer/trainer_test.py::TestTrainerGSM8KWithSFT::test_trainer	✅	64ms
tests/trainer/trainer_test.py::TestTrainerDPO::test_trainer	✅	55ms
tests/utils/plugin_test.py::TestPluginLoader::test_load_plugins	✅	4ms

Github Test Reporter by CTRF 💚

pan-x-c · 2025-06-12T07:23:01Z

/run-unittest

github-actions · 2025-06-12T07:40:48Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Pending ⏳	Other ❓	Flaky 🍂	Duration ⏱️
29	29	0	0	0	0	0	1.0s

Failed Tests

No failed tests ✨

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name	Status	Duration
tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer	✅	5ms
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer	✅	3ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid	✅	1ms
tests/common/config_test.py::TestConfig::test_load_default_config	✅	5ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion	✅	1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion	✅	1ms
tests/common/vllm_test.py::TestModelWrapperSyncV0::test_generate	✅	45ms
tests/common/vllm_test.py::TestModelWrapperAsyncV0::test_generate	✅	43ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV0::test_generate	✅	52ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV1::test_generate	✅	52ms
tests/common/vllm_test.py::TestModelWrapperAsyncV1::test_generate	✅	39ms
tests/common/vllm_test.py::TestAPIServer::test_api	✅	22ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask	✅	1ms
tests/explorer/explorer_test.py::BaseExplorerCase::test_explorer	✅	1ms
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer	✅	116ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer	✅	147ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool	✅	23ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool_with_auxiliary_models	✅	4ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow	✅	1ms
tests/explorer/workflow_test.py::WorkflowTest::test_workflow_resettable	✅	1ms
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer	✅	1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer	✅	277ms
tests/trainer/trainer_test.py::TestTrainerGSM8K::test_trainer	✅	59ms
tests/trainer/trainer_test.py::TestTrainerGSM8KWithSFT::test_trainer	✅	65ms
tests/trainer/trainer_test.py::TestTrainerDPO::test_trainer	✅	55ms
tests/utils/plugin_test.py::TestPluginLoader::test_load_plugins	✅	4ms

Github Test Reporter by CTRF 💚

add sample strategy

b5822d3

pan-x-c changed the title ~~Add Sample~~ Add Sample Strategy Jun 12, 2025

hiyuchang reviewed Jun 12, 2025

View reviewed changes

trinity/algorithm/sample_strategy/sample_strategy.py Outdated Show resolved Hide resolved

hiyuchang reviewed Jun 12, 2025

View reviewed changes

trinity/algorithm/sample_strategy/sample_strategy.py Outdated Show resolved Hide resolved

hiyuchang reviewed Jun 12, 2025

View reviewed changes

trinity/algorithm/sample_strategy/sample_strategy.py Outdated Show resolved Hide resolved

fix typo

f438f3d

yanxi-chen approved these changes Jun 12, 2025

View reviewed changes

pan-x-c added 5 commits June 12, 2025 12:23

refactor sample strategy

5ce869a

fix pre-commit

0b6c5d2

fix dpo strategy

44d223e

fix stop

62f012f

clean code

5b8346d

fix global step

88da840

pan-x-c merged commit dc8cb0c into modelscope:algorithm_dev Jun 12, 2025
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Sample Strategy #78

Add Sample Strategy #78

Uh oh!

pan-x-c commented Jun 11, 2025

Uh oh!

pan-x-c commented Jun 11, 2025

Uh oh!

github-actions bot commented Jun 11, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yanxi-chen left a comment

Uh oh!

pan-x-c commented Jun 12, 2025

Uh oh!

github-actions bot commented Jun 12, 2025

Uh oh!

pan-x-c commented Jun 12, 2025

Uh oh!

github-actions bot commented Jun 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add Sample Strategy #78

Add Sample Strategy #78

Uh oh!

Conversation

pan-x-c commented Jun 11, 2025

Description

Checklist

Uh oh!

pan-x-c commented Jun 11, 2025

Uh oh!

github-actions bot commented Jun 11, 2025

Summary

Failed Tests

Flaky Tests

Skipped

Tests

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yanxi-chen left a comment

Choose a reason for hiding this comment

Uh oh!

pan-x-c commented Jun 12, 2025

Uh oh!

github-actions bot commented Jun 12, 2025

Summary

Failed Tests

Flaky Tests

Skipped

Tests

Uh oh!

pan-x-c commented Jun 12, 2025

Uh oh!

github-actions bot commented Jun 12, 2025

Summary

Failed Tests

Flaky Tests

Skipped

Tests

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants