Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions trinity/buffer/ray_wrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -169,3 +169,6 @@ def read(self) -> List:
raise NotImplementedError(
"read() is not implemented for FileWrapper, please use QUEUE instead"
)

def finish(self) -> None:
self.file.close()
12 changes: 12 additions & 0 deletions trinity/buffer/reader/file_reader.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import datasets
import transformers
from datasets import Dataset, load_dataset
from tqdm import tqdm

from trinity.buffer.buffer_reader import BufferReader
from trinity.common.config import BufferConfig, StorageConfig
Expand Down Expand Up @@ -34,11 +35,20 @@ def __init__(self, dataset: Dataset, max_epoch: int = 1, offset: int = 0):
for _ in range(self.current_offset):
next(self.iter)

# Initialize tqdm progress bar
self.total_steps = self.dataset_size * self.max_epoch
self.progress_bar = tqdm(
total=self.total_steps,
initial=self.current_epoch * self.dataset_size + self.current_offset,
desc="Dataset Progressing",
)

def read_batch(self, batch_size: int) -> List:
batch = []

while len(batch) < batch_size:
try:
self.progress_bar.update(1)
item = next(self.iter)
batch.append(item)
self.current_offset += 1
Expand All @@ -48,7 +58,9 @@ def read_batch(self, batch_size: int) -> List:
self.current_offset = 0

if self.current_epoch >= self.max_epoch:
self.progress_bar.close()
raise StopIteration
# Step to the next epoch
self.iter = iter(self.dataset)
return batch

Expand Down