[Feature] Return table for service and fix analysis bug#1240
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the evaluation and performance services by integrating formatted result tables directly into their API responses, providing a more structured and easily digestible summary of metrics. It also addresses a bug in the LLM judge analysis generation, ensuring that disclaimers are only appended to successfully generated analyses, thereby improving the robustness of the reporting mechanism. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a feature to return a formatted markdown table for evaluation and performance results in the service layer, which improves the usability of the API. It also includes a bug fix for handling errors during the generation of analysis reports. While these are valuable additions, I've identified two high-severity issues that could impact the correctness and stability of the evaluation process. One change may lead to non-deterministic judge model outputs, and another could cause runtime errors due to a potential type mismatch. Please see the detailed comments for suggestions on how to address these.
There was a problem hiding this comment.
Pull request overview
This PR enhances the EvalScope Flask service responses by adding a human-readable Markdown table for both evaluation and performance endpoints, and fixes a bug in analysis generation around which model identifier is used.
Changes:
- Add a
tablefield to/api/v1/eval/invokeresponses by building a Markdown pipe-table from JSON reports. - Add a
tablefield to/api/v1/perf/invokeresponses by building a Markdown pipe-table from perf benchmark results. - Fix analysis generation to skip storing LLM error strings and switch model identifier usage for
LLMJudge.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| evalscope/service/blueprints/perf.py | Builds a Markdown pipe-table from perf results and returns it in the service response. |
| evalscope/service/blueprints/eval.py | Builds a Markdown pipe-table from report JSONs and returns it in the service response. |
| evalscope/report/report.py | Adjusts LLMJudge initialization for analysis and skips analysis on [ERROR] responses. |
| evalscope/metrics/llm_judge.py | Changes default generation_config behavior for judge calls. |
No description provided.