Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the capability to pass custom Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the model_args parameter to the LLMJudge class, allowing for more flexible configuration of the judge model, similar to how it's done for evaluation targets. The change is well-contained and correctly passes the arguments down to the model initialization. However, there is a critical issue with the type hint for model_args which will cause a runtime error. I've left a comment with a suggestion to fix it.
Problem
Evaluation target comes with the
model_argsargument, which is very helpful for users to add customized headers to the OpenAI client, for example:However, the above
model_argsis not currently available for the judge LLM.Solution
Adding
model_argsto theLLMJudgeclass in theevalscope/metrics/llm_judge.pyand making sure it is used in theget_modelfunction.I verified that the modification worked well in my environment.