Conversation
|
Related Documentation No published documentation to review for changes on this repository. Write your first living document How did I do? Any feedback? |
Summary of ChangesHello @suluyana, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new feature to run built-in projects, like singularity_cinema, directly via a --project command-line argument. This is achieved by packaging the projects directory and using importlib.resources to access them. The singularity_cinema project itself has been updated, notably with a much-improved README.md and a switch from manim to remotion. The changes are well-structured. I've found a few areas for improvement regarding code duplication, error handling, and documentation accuracy.
| except Exception as e: | ||
| # Fallback: don't let help crash just because a resource is unavailable. | ||
| logger.warning(f'Could not list built-in projects: {e}') | ||
| return [] |
There was a problem hiding this comment.
Catching a broad Exception can hide bugs and make debugging harder. It's better to catch more specific exceptions that you anticipate from the importlib_resources operations. For example, ModuleNotFoundError might be more appropriate if the package isn't found. While the goal of not crashing the help text is valid, being more specific with exception handling improves code robustness.
| projects_root = importlib_resources.files('ms_agent').joinpath( | ||
| 'projects') | ||
| available = [] | ||
| if projects_root.exists(): | ||
| available = [ | ||
| p.name for p in projects_root.iterdir() if p.is_dir() | ||
| ] | ||
| raise ValueError( | ||
| f'Unknown project: {project}. Available: {available}') |
There was a problem hiding this comment.
This block of code duplicates the logic from list_builtin_projects. To improve maintainability and reduce redundancy, you should reuse the existing function.
| projects_root = importlib_resources.files('ms_agent').joinpath( | |
| 'projects') | |
| available = [] | |
| if projects_root.exists(): | |
| available = [ | |
| p.name for p in projects_root.iterdir() if p.is_dir() | |
| ] | |
| raise ValueError( | |
| f'Unknown project: {project}. Available: {available}') | |
| available = list_builtin_projects() | |
| raise ValueError( | |
| f'Unknown project: {project}. Available: {available}') |
| * 输出：subtitles/bilingual_subtitle_N.png列表，N为segment序号从1开始 | ||
| - 输入：illustration_prompts/segment_N.txt列表 | ||
| - 输出：images/illustration_N.png列表，N为segment序号从1开始 | ||
| 10. 生成背景，为纯色带有短视频title和slogans的图片 |
There was a problem hiding this comment.
The list of steps in the '技术原理流程' (Technical principle flow) section is missing step 9 ('生成字幕' - Generate subtitles). The list jumps from step 8 to 10. According to workflow.yaml and the previous version of this file, this step should be included for the documentation to be accurate.
| pillow | ||
| requests | ||
| pyyaml | ||
| dotenv |
There was a problem hiding this comment.
The dotenv package is listed as a dependency twice in this file (the first one is on line 1). Please remove this duplicate entry.
2 participants
Uploading deploy_llm_claude_sonnet_4_5_mllm_gemini_3_pro_image_gen_gemini_3_pro_image.mp4…