Skip to content

fix api endpoint#850

Merged
tastelikefeet merged 2 commits intomodelscope:mainfrom
tastelikefeet:fix/0204-1
Feb 4, 2026
Merged

fix api endpoint#850
tastelikefeet merged 2 commits intomodelscope:mainfrom
tastelikefeet:fix/0204-1

Conversation

@tastelikefeet
Copy link
Copy Markdown
Collaborator

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Run pre-commit install and pre-commit run --all-files before git commit, and passed lint check.
  • Documentation reflects the changes where applicable

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @tastelikefeet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an API endpoint configuration issue by systematically removing specific dashscope_extend_params from the generation_config in several YAML files within the code_genesis project. Additionally, it resets the openai_base_url and mllm_openai_base_url in the singularity_cinema/agent.yaml file, suggesting a move towards more generic or environment-driven API endpoint management rather than hardcoded values.

Highlights

  • API Configuration Cleanup: Removed specific dashscope_extend_params from the generation_config.extra_body section across multiple YAML files within the projects/code_genesis/ directory.
  • Endpoint URL Reset: Cleared the openai_base_url and mllm_openai_base_url values in projects/singularity_cinema/agent.yaml, and also removed its dashscope_extend_params.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • projects/code_genesis/architect.yaml
    • Removed dashscope_extend_params from generation_config.extra_body.
  • projects/code_genesis/coding.yaml
    • Removed dashscope_extend_params from generation_config.extra_body.
  • projects/code_genesis/file_design.yaml
    • Removed dashscope_extend_params from generation_config.extra_body.
  • projects/code_genesis/file_order.yaml
    • Removed dashscope_extend_params from generation_config.extra_body.
  • projects/code_genesis/install.yaml
    • Removed dashscope_extend_params from generation_config.extra_body.
  • projects/code_genesis/orchestrator.yaml
    • Removed dashscope_extend_params from generation_config.extra_body.
  • projects/code_genesis/refine.yaml
    • Removed dashscope_extend_params from generation_config.extra_body.
  • projects/code_genesis/user_story.yaml
    • Removed dashscope_extend_params from generation_config.extra_body.
  • projects/singularity_cinema/agent.yaml
    • Cleared the value for llm.openai_base_url.
    • Cleared the value for mllm.mllm_openai_base_url.
    • Removed dashscope_extend_params from generation_config.extra_body.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes hardcoded DashScope configurations from several YAML files, which appears to be a fix for an API endpoint. While this is a positive change, the refactoring has been applied inconsistently. The openai_base_url is cleared in projects/singularity_cinema/agent.yaml but remains hardcoded in all projects/code_genesis/*.yaml files. My review includes a suggestion to address this inconsistency to improve maintainability.

I am having trouble creating individual review comments. Click here to see my feedback.

projects/code_genesis/architect.yaml (14-15)

medium

Removing these DashScope-specific parameters is a good step. However, for consistency with the changes made in projects/singularity_cinema/agent.yaml, it would be beneficial to also clear the hardcoded openai_base_url from this file and other code_genesis/*.yaml files. This would improve maintainability by centralizing the endpoint configuration and avoiding hardcoded values, allowing the application to use a default or environment-configured URL.

@tastelikefeet tastelikefeet merged commit 91212b8 into modelscope:main Feb 4, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants