Conversation
Summary of ChangesHello @tastelikefeet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an API endpoint configuration issue by systematically removing specific Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes hardcoded DashScope configurations from several YAML files, which appears to be a fix for an API endpoint. While this is a positive change, the refactoring has been applied inconsistently. The openai_base_url is cleared in projects/singularity_cinema/agent.yaml but remains hardcoded in all projects/code_genesis/*.yaml files. My review includes a suggestion to address this inconsistency to improve maintainability.
I am having trouble creating individual review comments. Click here to see my feedback.
projects/code_genesis/architect.yaml (14-15)
Removing these DashScope-specific parameters is a good step. However, for consistency with the changes made in projects/singularity_cinema/agent.yaml, it would be beneficial to also clear the hardcoded openai_base_url from this file and other code_genesis/*.yaml files. This would improve maintainability by centralizing the endpoint configuration and avoiding hardcoded values, allowing the application to use a default or environment-configured URL.
Change Summary
Related issue number
Checklist
pre-commit installandpre-commit run --all-filesbefore git commit, and passed lint check.