fix: preserve 2D predictions in predict_with_generate DDP eval - #10048
Merged
hjh0119 merged 2 commits intoSep 7, 2026
Merged
Conversation
Pad generate outputs to the global max sequence length across ranks before accelerator.gather so predictions stay (batch, seq_len). Fixes modelscope#8256
hjh0119
approved these changes
Sep 7, 2026
Collaborator
|
thanks for your contribution, please pass the lint test |
Contributor
Author
|
Addressed the lint failure on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve 2D (batch, seq_len) predictions when predict_with_generate gathers across DDP ranks. Fixes #8256