[train] support target_parameters

[Jintao-Huang]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @Jintao-Huang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've implemented support for a new target_parameters argument in the LoRA training configuration. This enhancement allows users to specify which model parameters should be targeted for LoRA adaptation directly by their names, offering an alternative to the existing target_modules and target_regex options. This change improves flexibility in fine-tuning large language models.

Highlights

• LoRA Configuration: Introduced target_parameters to LoraConfig, enabling LoRA application based on parameter names.
• Documentation: Updated Chinese and English documentation files to describe the new target_parameters argument and its usage, including the peft version requirement.
• Dependency Management: Bumped the peft dependency version in requirements/framework.txt to allow versions up to <0.18, which is necessary for the new target_parameters feature.
• Codebase Integration: Integrated the target_parameters argument across relevant swift modules, including argument parsing and adapter preparation logic for both standard and Megatron training setups.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for the target_parameters argument in LoRA training, which allows for more precise control over which parameters are adapted. The changes are well-implemented across the documentation, requirements, and both the standard and Megatron training paths. The peft dependency has been correctly updated to support this new feature. I have one minor suggestion to improve type hint consistency.

[gemini-code-assist]

For consistency with other type hints in this file, such as target_modules and modules_to_save, it's better to use List[str] from the typing module instead of the built-in list[str]. This will ensure uniformity across the codebase.

Suggested change

	target_parameters: Optional[list[str]] = None
	target_parameters: Optional[List[str]] = None