Skip to content

Conversation

@hpsun1109
Copy link
Contributor

@hpsun1109 hpsun1109 commented Oct 23, 2025

PR type

  • Bug Fix
  • New Feature
  • Document Updates
  • More Models or Datasets Support

PR information

Write the detail information belongs to this PR.

Experiment results

Paste your experiment result here(if needed).

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hpsun1109, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the SeedAgentTemplate into the system, enabling support for the Seed model's unique agent capabilities, particularly its tool-calling mechanism. It enhances the core template functionality to handle a 'thinking budget' and provides comprehensive logic for formatting tool definitions, calls, and responses, ensuring seamless interaction with the Seed model. The changes are validated with a new test case.

Highlights

  • New Agent Template: Introduced a new SeedAgentTemplate to support the specific tool-calling and prompt formatting requirements of the Seed model.
  • Thinking Budget Integration: Added functionality to the base template to recognize and utilize a thinking_budget parameter, allowing for more nuanced control over model behavior in certain scenarios.
  • Tool Call and Response Handling: The new SeedAgentTemplate includes custom logic for parsing tool calls from model responses, formatting tool definitions, and integrating tool outputs into the conversation flow.
  • Test Coverage: A dedicated test case (test_seed_oss) has been added to validate the correct functioning of the SeedAgentTemplate, ensuring its proper integration and behavior.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces SeedAgentTemplate to support the Seed-OSS model, including its custom tool-calling format. The changes are well-structured, adding the new agent template, registering it, and providing a corresponding test case. My review includes suggestions to improve code quality by adhering to idiomatic Python practices, enhancing readability, and fixing a potential TypeError from improper handling of an optional system parameter. I've also pointed out a style issue in the new test file.

parameters = func.get('parameters', {})
properties = parameters.get('properties', {})
params = [f"{name}: {self._py_type(spec.get('type', 'any'))}" for name, spec in properties.items()]
param_str = ','.join(params)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and to follow PEP 8 conventions, it's good practice to add a space after the comma when joining strings.

Suggested change
param_str = ','.join(params)
param_str = ', '.join(params)

encoded = template.encode(data)
print(f'input_ids: {template.safe_decode(encoded["input_ids"])}')
print(f'labels: {template.safe_decode(encoded["labels"])}')
import re
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to PEP 8, imports should usually be at the top of the file, not inside a function. Please move import re to the top of the file with other imports.

hpsun1109 and others added 9 commits October 23, 2025 14:17
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant