Make the default value of fsdp compatible with transformers less than 4.57

[slin000111]

PR type

• Bug Fix
• New Feature
• Document Updates
• More Models or Datasets Support

PR information

Write the detail information belongs to this PR.

Make the default value of fsdp compatible with transformers less than 4.57

Experiment results

Paste your experiment result here(if needed).

[gemini-code-assist]

Summary of Changes

Hello @slin000111, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a compatibility issue with older versions of the transformers library, specifically those prior to 4.57. It modifies the FSDP (Fully Sharded Data Parallel) initialization logic to ensure that if the fsdp argument is not provided or is falsy, it defaults to an empty list. This change prevents potential errors that could arise when using the system with older transformers versions that might expect fsdp to be an iterable, even when no FSDP configuration is desired.

Highlights

• FSDP Compatibility Fix: Ensured compatibility with transformers library versions older than 4.57 by explicitly initializing the fsdp configuration as an empty list when it is not set.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a compatibility issue with certain versions of the transformers library by setting a default value for the fsdp argument. My review focuses on improving the type consistency of the proposed change. The fix is functionally correct, but it can be improved to align with the existing type hints for better code quality and maintainability.

[gemini-code-assist]

While setting self.fsdp = [] fixes the compatibility issue, it introduces a type inconsistency. The fsdp attribute is type-hinted as Optional[str] on line 204, but you are assigning a list to it. To maintain type consistency, it would be better to set it to an empty string "". This is also a safe "disabled" value across different transformers versions and respects the established type hint.

Suggested change

	self.fsdp = []
	self.fsdp = ""