[bugfix] fix dataset hash #7916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjh0119
approved these changes
Jan 27, 2026
Collaborator
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug related to non-deterministic ordering of candidate_templates, which likely caused issues with dataset hashing. The fix correctly uses dict.fromkeys to ensure a unique and order-preserved list of templates. The change is effective and improves the robustness of the code. I have one suggestion to slightly refactor the implementation for better readability.
Comment on lines
+90
to
+91
| self.candidate_templates = list( | ||
| dict.fromkeys(t for t in [self.template] + [mg.template for mg in self.model_groups] if t is not None)) |
Contributor
There was a problem hiding this comment.
While the use of dict.fromkeys is a clever way to get unique elements while preserving order, the single line is quite long and a bit hard to read. Consider breaking it into two lines for improved readability and to adhere to common line length limits.
Suggested change
| self.candidate_templates = list( | |
| dict.fromkeys(t for t in [self.template] + [mg.template for mg in self.model_groups] if t is not None)) | |
| templates = [self.template] + [mg.template for mg in self.model_groups] | |
| self.candidate_templates = list(dict.fromkeys(t for t in templates if t is not None)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.