Skip to content

[megatron]delete cpu sync #8447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yangbofun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[megatron]delete cpu sync #8447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions swift/megatron/init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,12 +745,7 @@ def _apply_rotary_pos_emb_thd(
Returns:
Tensor: Shape [t, h, d]. The input tensor after applying RoPE.
"""
if cp_group is not None:
cp_size = cp_group.size()
else:
cp_size = mpu.get_context_parallel_world_size()
cu_seqlens_for_batched = cu_seqlens // cp_size
use_batched_rope = (freqs.dim() >= 1 and freqs.shape[0] == cu_seqlens_for_batched[-1]).item()
use_batched_rope = freqs.dim() >= 1 and freqs.shape[0] == t.shape[0]
if not use_batched_rope:
logger.warning_once('Using non-batched RoPE, which may affect performance.')
kwargs = {'cp_group': cp_group} if mcore_013 else {}
Expand Down