Skip to content

Fix message access in infer_requests #9073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YeewahChan wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Fix message access in infer_requests #9073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion swift/pipelines/sampling/distill_sampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def infer(
for infer_request in infer_requests:
completion = self.client.chat.completions.create(
model=self.model,
messages=infer_request['messages'],
messages=infer_request.messages,
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change from dictionary-style access (infer_request['messages']) to attribute-style access (infer_request.messages) will cause a runtime AttributeError. The infer_requests list passed to this infer method is populated with dictionaries in DistillSampler.generate, not InferRequest objects. As infer_request is a dictionary, attribute access is not possible.

Please revert this change to use infer_request['messages'] to avoid breaking the code.

Suggested change
messages=infer_request.messages,
messages=infer_request['messages'],

temperature=request_config.temperature,
top_p=request_config.top_p,
max_tokens=request_config.max_tokens,
Expand Down