Replace BenchmarkTools.jl with Chairmarks.jl in Optimizing #138
Conversation
| \advanced{ | ||
| Certain computations may be [optimized away by the compiler]((https://juliaci.github.io/BenchmarkTools.jl/stable/manual/#Understanding-compiler-optimizations)) before the benchmark takes place. | ||
| If you observe suspiciously fast performance, especially below the nanosecond scale, this is very likely to have happened. | ||
| } |
There was a problem hiding this comment.
This can now be removed (or updated for Chairmarks @LilithHafner ?).
There was a problem hiding this comment.
It's always possible to optimize away computation unintentionally
julia> @btime 10+20+30+40+50
1.167 ns (0 allocations: 0 bytes)
150
julia> @b 10+20+30+40+50
1.241 nsUsing Chairmarks does not mean we no longer need to worry about this.
Also, BenchmarkTools.jl's docs are great for this. Chairmarks does not have a better alternative.
There was a problem hiding this comment.
I think readers might be confused by a link to BenchmarkTools in what is now a section about Chairmarks.
If this is crucial information and Chairmarks replaces BenchmarkTools, maybe the Chairmarks docs should mirror the contents?
If this is not crucial, maybe we should remove it from MoJuWo entirely.
There was a problem hiding this comment.
Maybe just clarify that the explanation from BenchmarkTools applies here too
| \advanced{ | ||
| Certain computations may be [optimized away by the compiler]((https://juliaci.github.io/BenchmarkTools.jl/stable/manual/#Understanding-compiler-optimizations)) before the benchmark takes place. | ||
| If you observe suspiciously fast performance, especially below the nanosecond scale, this is very likely to have happened. | ||
| } |
There was a problem hiding this comment.
Maybe just clarify that the explanation from BenchmarkTools applies here too
Co-authored-by: Guillaume Dalle <[email protected]>
Closes #133.