Open
Conversation
crstauf
approved these changes
Mar 18, 2026
MlKilderkin
approved these changes
Mar 18, 2026
dpellenwood
requested changes
Mar 27, 2026
Collaborator
dpellenwood
left a comment
dpellenwood
left a comment
There was a problem hiding this comment.
Hmm... I don't think we can load the plugin like this into ModernPress as this repo is public and we're effectively giving away a 3rd-party's proprietary code. We'll need to discuss an alternative for how we handle this plugin in our public repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do/fix?
Add support for FacetWP plugin. Unfortunately, FacetWP doesn't support installation via composer. Related to #327.
QA
Links to relevant issues