[MOOSE-353]: Add new announcements settings#337
Merged
MlKilderkin merged 4 commits intomainfrom Mar 31, 2026
Merged
Conversation
dpellenwood
approved these changes
Mar 27, 2026
Collaborator
dpellenwood
left a comment
There was a problem hiding this comment.
🍏 Looks great overall, Myk. I'd like Geoff's input on the editor styles a bit before it merges though.
| --announcement-dismiss-width: 106px; | ||
| } | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
I'd like to see these css selectors nested a bit, and I wonder if we want to use a container query here rather than viewport queries. @GeoffDusome , I'd be curious your thoughts on this, too.
GeoffDusome
approved these changes
Mar 27, 2026
Contributor
GeoffDusome
left a comment
There was a problem hiding this comment.
🟢 Seems to work great, Myk. Thanks for tackling. I pushed a commit to fix some of the styling and just generally clean things up. Should be good to go now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do/fix?
QA
Links to relevant issues