Skip to content

[MOOSE-353]: Add new announcements settings#337

Merged
MlKilderkin merged 4 commits intomainfrom
feature/MOOSE-353/stack-on-desktp
Mar 31, 2026
Merged

[MOOSE-353]: Add new announcements settings#337
MlKilderkin merged 4 commits intomainfrom
feature/MOOSE-353/stack-on-desktp

Conversation

@MlKilderkin
Copy link
Copy Markdown
Contributor

@MlKilderkin MlKilderkin commented Mar 27, 2026

What does this do/fix?

  1. In the ‘Setup’ tab, add a new setting called “Orientation”
  2. Options for Horizontal (default) and Vertical
  3. Mobile will always be stacked. Desktop will use this option.
  4. When Vertical layout is applied, Dismiss button should be top aligned.
  5. When Vertical layout is applied, the content should have a max-width, and there should be be sufficient padding between content and dismiss button. (See screenshot)
  6. Add the same functionality to the ‘Announcements’ block as well.

QA

Links to relevant issues

7A551445-9BB8-4393-A64D-BC1CA6EA5296 F9DF4B06-3BAB-4C73-85F1-21092C893659 294EC801-D0CA-41AE-BCC5-806BA6198CC8 D8A0C42D-5C5D-4F32-A65D-529EE272A0F3 C6260A32-54CF-440D-92F7-D3E92C1B3A71

Copy link
Copy Markdown
Collaborator

@dpellenwood dpellenwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏 Looks great overall, Myk. I'd like Geoff's input on the editor styles a bit before it merges though.

--announcement-dismiss-width: 106px;
}
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see these css selectors nested a bit, and I wonder if we want to use a container query here rather than viewport queries. @GeoffDusome , I'd be curious your thoughts on this, too.

Copy link
Copy Markdown
Contributor

@GeoffDusome GeoffDusome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Seems to work great, Myk. Thanks for tackling. I pushed a commit to fix some of the styling and just generally clean things up. Should be good to go now.

@MlKilderkin MlKilderkin added In QA Waiting on QA Ready to Merge and removed Launch Environment Deploys to dokku In QA Waiting on QA labels Mar 30, 2026
@MlKilderkin MlKilderkin merged commit 96fdd65 into main Mar 31, 2026
7 checks passed
@MlKilderkin MlKilderkin deleted the feature/MOOSE-353/stack-on-desktp branch March 31, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants