Open
Conversation
crstauf
approved these changes
Mar 30, 2026
MlKilderkin
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do/fix?
This pull request refines the logic for retrieving post type subscribers in the admin menu order functionality. The main change is to improve how post type subscribers are filtered and which ones are skipped, making the code more efficient and accurate.
Improvements to post type subscriber filtering:
get_post_types()to only include subscribers containing'Post_Types\', usingarray_filterfor better clarity and efficiency.'Tribe\Plugin\Post_Types\Page\Page_Subscriber') instead of generic post type names, ensuring only the intended subscribers are excluded.QA
Links to relevant issues
Screenshots/video:
Pull request checklist