Skip to content

[MOOSE-368] BE: Fix Admin Menu Order#338

Open
GeoffDusome wants to merge 4 commits intomainfrom
fix/MOOSE-368/admin-menu-order
Open

[MOOSE-368] BE: Fix Admin Menu Order#338
GeoffDusome wants to merge 4 commits intomainfrom
fix/MOOSE-368/admin-menu-order

Conversation

@GeoffDusome
Copy link
Copy Markdown
Contributor

What does this do/fix?

This pull request refines the logic for retrieving post type subscribers in the admin menu order functionality. The main change is to improve how post type subscribers are filtered and which ones are skipped, making the code more efficient and accurate.

Improvements to post type subscriber filtering:

  • Updated the filtering in get_post_types() to only include subscribers containing 'Post_Types\', using array_filter for better clarity and efficiency.
  • Refined the list of post type subscribers to skip by specifying the full class names (e.g., 'Tribe\Plugin\Post_Types\Page\Page_Subscriber') instead of generic post type names, ensuring only the intended subscribers are excluded.

QA

Links to relevant issues

Screenshots/video:

Pull request checklist

  • I've added a changelog entry for these changes.
  • I've linked to a relevant Jira issue.
  • I've captured a screenshot or screencast of the changes and linked it above.

Copy link
Copy Markdown
Collaborator

@dpellenwood dpellenwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏

@GeoffDusome GeoffDusome added In QA Waiting on QA and removed Needs BE Review labels Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

In QA Waiting on QA Launch Environment Deploys to dokku

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants