MOOSE-333: Scroll vertical tabs into view on mobile after selection #306
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a vertical tab is clicked on mobile, the viewport now scrolls to show the selected tab at the top. Added scroll-margin-top to account for the sticky header.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements automatic scrolling functionality for vertical tabs on mobile devices. When a tab is selected, the viewport smoothly scrolls to bring that tab into view at the top of the screen, while respecting user accessibility preferences for reduced motion.
Changes:
- Added CSS scroll margin to account for sticky header positioning on mobile
- Implemented JavaScript scroll behavior that activates only on mobile when tabs merge
- Updated changelog to document the fix
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| wp-content/themes/core/blocks/tribe/vertical-tabs/style.pcss | Adds scroll-margin-top for mobile to account for sticky header height |
| wp-content/themes/core/assets/js/utils/tabs.js | Implements scrollIntoView behavior on mobile with reduced motion support |
| CHANGELOG.md | Documents the fix for vertical tabs scrolling behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GeoffDusome
approved these changes
Jan 21, 2026
Contributor
GeoffDusome
left a comment
GeoffDusome
left a comment
There was a problem hiding this comment.
🟢 Looks good to me; I think we initially had it this way but we removed it for some reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do/fix?
When a vertical tab is clicked on mobile, the viewport now scrolls to show the selected tab at the top. It also takes into consideration
prefers-reduced-motionwhen animating in.QA
Links to relevant issues
Screenshots/video:
Pull request checklist