Skip to content

fix: bump pipelines Ubuntu 24.04 and update playwright #2879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 11, 2025
Merged

fix: bump pipelines Ubuntu 24.04 and update playwright #2879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e621ea
chore: bump pipelines Ubuntu to latest 24.04
bashmish Jan 31, 2025
ee36d04
chore: workaround for Chrome sandbox in Ubuntu 24.04
bashmish Feb 3, 2025
0260bc7
chore: bump playwright version to latest which works in GitHub Action…
bashmish Jan 31, 2025
dbd6f47
chore: release @web/test-runner-playwright with latest playwright
bashmish Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tidy-hairs-hope.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@web/test-runner-playwright': patch
---

bump playwright
2 changes: 1 addition & 1 deletion .github/workflows/canary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
# Prevents changesets action from creating a PR on forks
if: github.repository == 'modernweb-dev/web'
name: Pre-release
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
steps:
- name: Checkout Repo
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
linux:
timeout-minutes: 30
name: Linux
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
# Prevents changesets action from creating a PR on forks
if: github.repository == 'modernweb-dev/web'
name: Release
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
steps:
- name: Checkout Repo
uses: actions/checkout@v4
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/verify-browser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,16 @@ jobs:
verify-linux:
timeout-minutes: 30
name: Linux
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- uses: actions/checkout@v4

# TODO: remove when GitHub fixes this https://github.com/actions/runner-images/issues/10015
# (this workaround is practically the same what Playwright did in https://github.com/microsoft/playwright/pull/34238/files)
- name: Workaround for Chrome sandbox issue in Ubuntu 24.04
run: sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0

- name: Setup Node 20
uses: actions/setup-node@v4
env:
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/verify-node.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
verify-linux:
timeout-minutes: 30
name: Linux
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
strategy:
fail-fast: false
matrix:
Expand All @@ -22,6 +22,11 @@ jobs:
steps:
- uses: actions/checkout@v4

# TODO: remove when GitHub fixes this https://github.com/actions/runner-images/issues/10015
# (this workaround is practically the same what Playwright did in https://github.com/microsoft/playwright/pull/34238/files)
- name: Workaround for Chrome sandbox issue in Ubuntu 24.04
run: sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0

- name: Setup Node ${{ matrix.node-version }}
uses: actions/setup-node@v4
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/verify-storybook-builder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
strategy:
fail-fast: false
matrix:
runs-on: [ubuntu-22.04, windows-2022]
runs-on: [ubuntu-24.04, windows-2022]
runs-on: ${{ matrix.runs-on }}
name: ${{ matrix.runs-on }}
timeout-minutes: 60
Expand Down
41 changes: 20 additions & 21 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/storybook-framework-web-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"@web/storybook-builder": "^0.2.2"
},
"devDependencies": {
"@playwright/test": "^1.22.2",
"@playwright/test": "^1.53.0",
"@storybook/addon-a11y": "^8.6.12",
"@storybook/addon-essentials": "^8.6.12",
"@storybook/addon-interactions": "^8.6.12",
Expand Down
2 changes: 1 addition & 1 deletion packages/test-runner-playwright/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"dependencies": {
"@web/test-runner-core": "^0.13.0",
"@web/test-runner-coverage-v8": "^0.8.0",
"playwright": "^1.22.2"
"playwright": "^1.53.0"
},
"devDependencies": {
"@web/test-runner-mocha": "^0.9.0",
Expand Down