refactor(config-loader): do not lookup package.json with explicit extensions
#2915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d432f57 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
@devversion thanks for the fix! Please add a changeset (with a patch bump) following the previous comment notes, then I can release it too. |
…xtensions Currently when a config has an explicit extension, the config-loader still tries resolving/traversing for a `package.json` file. This can be slow, and also break in some environments with sandboxing; especially when used in combination with Bazel. It doesn't seem investigating why the calls are stuck, if the logic should not run in general when an explicit extension is provided.
Contributor
Author
|
@bashmish done! |
Member
|
Thanks! Will release shortly. |
Contributor
Author
|
Thanks for the super quick review & merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a config has an explicit extension, the config-loader still tries resolving/traversing for a
package.jsonfile. This can be slow, and also break in some environments with sandboxing; especially when used in combination with Bazel.It doesn't seem investigating why the calls are stuck, if the logic should not run in general when an explicit extension is provided.