fix(test-runner-chrome): remove focus browser patches #2928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patches were added quite a while ago, and the upstream issues should be resolved in Chromium. See: https://issues.chromium.org/issues/40272146. Also see: puppeteer/puppeteer#10350 (comment). The patches are currently also resulting some instability of web test runner. That is because the patch calls an exposed function from inside the browser, while navigation later on during `stopSession` can happen; breaking the handle for retrieving function call arguments passed to the exposed function. Puppeteer team found this issue and also landed a fix to improve the failure mode here. See: puppeteer/puppeteer#13759
🦋 Changeset detectedLatest commit: 24e3290 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This should make debugging easier. It wasn't very easy to figure out where the errors originated from (because of how the actual uncaught exception only happened with many concurrent builds inside a sandbox environment that is hard to debug)
Member
|
Thanks for a clear explainer with all the relevant links in it, great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit descriptions.