fix: expand esbuild semver range #3005
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1e14f30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
esbuild recently published a new major which means installs of WDS duplicate it currently, since we're bound to `0.25.0`. this just expands the semver range so we can de-dupe. Note this doesn't upgrade the locally installed esbuild (in this repo) as the storybook package uses storybook 8.x which still uses the older esbuild. So it means we would have 2 esbuild installs.
43081j
force-pushed
the
esbuild-ranges
branch
from
c9c72b9 to
1e14f30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
esbuild recently published a new major which means installs of WDS
duplicate it currently, since we're bound to
0.25.0. this just expandsthe semver range so we can de-dupe.
Note this doesn't upgrade the locally installed esbuild (in this repo)
as the storybook package uses storybook 8.x which still uses the older
esbuild. So it means we would have 2 esbuild installs.