factor out function for structured grid dims workaround #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in lieu of an xarray index for structured grids to provide layer/row/column indexing on arrays even when they are defined in terms of nodes, reshape flat arrays to structured grid dims in the converter for now. Co-authored-by: mjreno <[email protected]>
wpbonelli
added
requirement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in lieu of an xarray index for structured grids to provide layer/row/column indexing on arrays even when they are defined in terms of nodes, we reshape flat arrays to structured grid dims in the converter for now. move this out into a function so it's more obvious it's temporary.
introduced by @mjreno in #196. I sullied that PR with all kinds of conflicts so pulling this in separately.