Skip to content

Conversation

@mjreno
Copy link
Contributor

@mjreno mjreno commented Nov 13, 2025

Basic testing for examples:

  • compare standard budget, binary grid and head files to example output
  • add standards under test/__compare__/test_examples with the example name as file stem name
  • first step baseline sanity checks for full examples

@mjreno mjreno changed the title broaden array package testing add array package tests Nov 13, 2025
@mjreno mjreno changed the title add array package tests add example snapshot head checks Nov 14, 2025
@mjreno mjreno changed the title add example snapshot head checks add compare for example outputs Nov 15, 2025
@mjreno mjreno changed the title add compare for example outputs add compare check for example outputs Nov 16, 2025
@mjreno mjreno requested a review from wpbonelli November 16, 2025 14:39
Copy link
Member

@wpbonelli wpbonelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, did you find it was easier to just manually compare than use the snapshot fixtures for now?

@mjreno
Copy link
Contributor Author

mjreno commented Nov 16, 2025

looks good to me, did you find it was easier to just manually compare than use the snapshot fixtures for now?

I had some cross platform failures with the npy files, similar to what you've mentioned. I tried using pytest.approx, which adds tolerances to the files once regenerated (this made lots of snapshot files) but it didn't address the failures. I wasn't sure about support for other file types (like json would be good for the gdb checks)- anyways it can go in any sensible direction from here but this was just a straight forward way to get some basic sanity checks in.

@mjreno mjreno merged commit 637b3bc into modflowpy:develop Nov 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants