REFACTOR: Add mypy checks for modin.core.dataframe.algebra #5167
Open
yashgosa wants to merge 3 commits intomodin-project:masterfrom
Open
REFACTOR: Add mypy checks for modin.core.dataframe.algebra #5167yashgosa wants to merge 3 commits intomodin-project:masterfrom
yashgosa wants to merge 3 commits intomodin-project:masterfrom
Conversation
Author
|
@pyrito @mvashishtha guys I aint able to understand why is this error occurring |
|
This pull request introduces 1 alert when merging 797a888 into 6f0ff79 - view on LGTM.com new alerts:
|
Author
@pyrito can you please help me out |
pyrito
reviewed
Oct 31, 2022
Author
|
@mvashishtha can you please review the code now I don't think so there should be any issues, if there are some changes required do tell me |
Collaborator
|
@sofezticated-gentleman I still see quite a lot of formatting changes, e.g. in modin/_compat/pandas_api/py36/base.py. Could you please revert all those and push to your branch again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date