-
Notifications
You must be signed in to change notification settings - Fork 675
FEAT-#7549: Emit metrics on auto-switch and casting behavior #7550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
52ba89a
FEAT-#7549: Emit metrics on auto-switch and casting behavior
sfc-gh-jkew f799396
Add test for metrics for casting
sfc-gh-jkew c13618e
Remove extranious stuff
sfc-gh-jkew c69d173
format imports
sfc-gh-jkew 6c611ae
isort fix
sfc-gh-jkew ec1a1cb
More meaningful names for the metrics values
sfc-gh-jkew 719621d
Update tests and move group number to end
sfc-gh-jkew 70a8a6f
Allow for metrics to be added without breaking the existing metrics t…
sfc-gh-jkew 8fb0b0b
WIP
sfc-gh-jkew 49b83d1
Refactor metrics a bit to be easier to process. Switch to using a ran…
sfc-gh-jkew 65ce3f0
update test
sfc-gh-jkew 1ed78a2
isort
sfc-gh-jkew 6f11bbb
add back deleted metrics len check
sfc-gh-joshi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was originally a monotonic counter, right? Why is it random now?