Skip to content

FIX-#7578: Change groupby extension allow list and fix cached_property extensions#7579

Merged
sfc-gh-joshi merged 4 commits intomodin-project:mainfrom
sfc-gh-joshi:joshi/groupby-internal-by-default
May 23, 2025
Merged

FIX-#7578: Change groupby extension allow list and fix cached_property extensions#7579
sfc-gh-joshi merged 4 commits intomodin-project:mainfrom
sfc-gh-joshi:joshi/groupby-internal-by-default

Conversation

@sfc-gh-joshi
Copy link
Contributor

What do these changes do?

Fixes the linked issue by calling set_name on extensions defined with the cached_property decorator, and loosens restrictions on methods that can be extended on DataFrameGroupBy and SeriesGroupBy objects.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: Using extensions to override a cached_property causes an error #7578
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

…ached_property extensions

Signed-off-by: Jonathan Shi <jonathan.shi@snowflake.com>
Copy link
Contributor

@sfc-gh-mvashishtha sfc-gh-mvashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I am requesting one small change.

Co-authored-by: Mahesh Vashishtha <mahesh.vashishtha@snowflake.com>
@sfc-gh-joshi sfc-gh-joshi enabled auto-merge (squash) May 23, 2025 01:28
@sfc-gh-joshi sfc-gh-joshi merged commit 8600760 into modin-project:main May 23, 2025
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Using extensions to override a cached_property causes an error

2 participants