FIX-#7551: Fix name ambiguity for value_counts() on Pandas backend#7585
Merged
sfc-gh-joshi merged 12 commits intomodin-project:mainfrom Jun 9, 2025
Merged
Conversation
sfc-gh-vrpatel
force-pushed
the
value_counts_pandas_patch
branch
from
299ef3a to
5e2fe6b
Compare
sfc-gh-joshi
requested changes
May 27, 2025
sfc-gh-joshi
requested changes
May 28, 2025
sfc-gh-vrpatel
requested review from
a team,
RehanSD,
YarShev,
anmyachev,
dchigarev,
devin-petersohn,
mvashishtha and
vnlitvinov
as code owners
sfc-gh-joshi
requested changes
May 30, 2025
Contributor
sfc-gh-joshi
left a comment
sfc-gh-joshi
left a comment
There was a problem hiding this comment.
One minor test style thing.
Take a look at the auto-generated codecov warnings as well: it looks like there might be some parameter combinations not being covered by your tests. They might be false positives (if you set a breakpoint in one of the branches and it gets hit, then it probably is), but double check just to make sure
…ndas backend Aims to fix a name ambiguity bug in `value_counts()` with a patch on `sort_values()` on the Pandas backend. Signed-off-by: Vraj Patel <vraj.patel@snowflake.com>
Signed-off-by: Vraj Patel <vraj.patel@snowflake.com>
Signed-off-by: Vraj Patel <vraj.patel@snowflake.com>
Signed-off-by: Vraj Patel <vraj.patel@snowflake.com>
Signed-off-by: Vraj Patel <vraj.patel@snowflake.com>
Signed-off-by: Vraj Patel <vraj.patel@snowflake.com>
sfc-gh-vrpatel
force-pushed
the
value_counts_pandas_patch
branch
from
6992211 to
a337d0e
Compare
Signed-off-by: Vraj Patel <vraj.patel@snowflake.com>
Signed-off-by: Vraj Patel <vraj.patel@snowflake.com>
sfc-gh-joshi
requested changes
Jun 3, 2025
Signed-off-by: Vraj Patel <vraj.patel@snowflake.com>
sfc-gh-joshi
reviewed
Jun 5, 2025
Signed-off-by: Vraj Patel <vraj.patel@snowflake.com>
Signed-off-by: Vraj Patel <vraj.patel@snowflake.com>
sfc-gh-joshi
approved these changes
Jun 6, 2025
Contributor
sfc-gh-joshi
left a comment
sfc-gh-joshi
left a comment
There was a problem hiding this comment.
Changes LGTM, but it looks like CI for the Python engine is failing (https://github.com/modin-project/modin/actions/runs/15478865456/job/43580614471?pr=7585). You might need to expand the conditions for the xfail even more.
Signed-off-by: Vraj Patel <vraj.patel@snowflake.com>
sfc-gh-mvashishtha
pushed a commit
that referenced
this pull request
Jun 18, 2025
…7585) Implements index renaming for `sort_rows_by_column_values()` in the Pandas backend, similarly as in the Ray backend, to fix the name ambiguity error in `value_counts()`. Signed-off-by: Vraj Patel <vraj.patel@snowflake.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Implements index renaming for
sort_rows_by_column_values()in the Pandas backend, similarly as in the Ray backend, to fix the name ambiguity error invalue_counts().flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sValueError: '0' is both an index level and a column label, which is ambiguous.#7551docs/development/architecture.rstis up-to-date