Skip to content

FIX-#7582: [DRAFT] Test fix for array copy parameter on python 3.10, with cumprod fix #7592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sfc-gh-mvashishtha wants to merge 3 commits into from
Closed

FIX-#7582: [DRAFT] Test fix for array copy parameter on python 3.10, with cumprod fix #7592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6ff9ab
FIX-#7582: [DRAFT] Test fix for array copy parameter on python 3.10
sfc-gh-mvashishtha May 27, 2025
f5375a1
Use cumprod instead of cumproduct, which does not exist in numpy >= 2
sfc-gh-mvashishtha May 28, 2025
945b136
Remove warnings check
sfc-gh-mvashishtha May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
steps:
- id: choose
run: |
if [[ "${{ github.event.schedule }}" = "30 2 * * WED" ]]
if true
then
echo "python-version=3.10" >> "$GITHUB_OUTPUT"
elif [[ "${{ github.event.schedule }}" = "30 2 * * THU" ]]
Expand Down
3 changes: 1 addition & 2 deletions modin/tests/pandas/dataframe/test_udf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,7 @@ def test_aggregate_error_checking():
with warns_that_defaulting_to_pandas():
modin_df.aggregate({modin_df.columns[0]: "sum", modin_df.columns[1]: "mean"})

with warns_that_defaulting_to_pandas():
modin_df.aggregate("cumproduct")
modin_df.aggregate("cumprod")


@pytest.mark.parametrize(
Expand Down
Loading