FIX-#7595: Log backend switching information with the modin logger.#7597
Merged
sfc-gh-mvashishtha merged 1 commit intomodin-project:mainfrom May 30, 2025
Conversation
…din logger. Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
sfc-gh-mvashishtha
requested review from
a team,
RehanSD,
YarShev,
anmyachev,
dchigarev,
devin-petersohn,
mvashishtha and
vnlitvinov
as code owners
sfc-gh-jkew
approved these changes
May 30, 2025
| pd.read_json(StringIO(small_json)).get_backend() == "Small_Data_Local" | ||
| ) | ||
|
|
||
| @backend_test_context( |
Contributor
There was a problem hiding this comment.
This testing seems like a bit of overkill but OK.
sfc-gh-joshi
approved these changes
May 30, 2025
Contributor
sfc-gh-joshi
left a comment
sfc-gh-joshi
left a comment
There was a problem hiding this comment.
Should we use a different logging namespace for cost calculation/switching behavior? Otherwise LGTM.
Contributor
Author
I think that would be ideal, but for now I'm following the pattern we seem to have in modin of logging everything under a single namespace. |
sfc-gh-mvashishtha
added a commit
that referenced
this pull request
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7595