FIX-#7684: When we exceed max_cost for all available Backends an error may occur #7685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jkew
changed the title
sfc-gh-jkew
changed the title
sfc-gh-jkew
changed the title
sfc-gh-jkew
requested review from
a team,
RehanSD,
YarShev,
anmyachev,
dchigarev,
devin-petersohn,
mvashishtha and
vnlitvinov
as code owners
sfc-gh-mvashishtha
approved these changes
Oct 1, 2025
sfc-gh-mvashishtha
pushed a commit
that referenced
this pull request
Oct 2, 2025
…r may occur (#7685) The BackendCostCalculator was originally designed to return None when no suitable backend was available. It would do this when the max_cost of all backend were exceeded. In practice, and with changes related to considering multiple backends for pre-operation switches it was realized that this was too restrictive and it would throw a ValueError under certain workloads. This change allows the calculator to first calculate a backend considering max_cost but, if one is not found, then calculate one disregarding max_cost. A backend should always be returned in this case. ## What do these changes do? - [x] first commit message and PR title follow format outlined [here](https://modin.readthedocs.io/en/latest/development/contributing.html#commit-message-formatting) > **_NOTE:_** If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title. - [x] passes `flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py` - [x] passes `black --check modin/ asv_bench/benchmarks scripts/doc_checker.py` - [x] signed commit with `git commit -s` <!-- you can amend your commit with a signature via `git commit -amend -s` --> - [x] Resolves #7684 - [x] tests added and passing - [x] module layout described at `docs/development/architecture.rst` is up-to-date <!-- if you have added, renamed or removed files or directories please update the documentation accordingly -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BackendCostCalculator was originally designed to return None when no suitable backend was available. It would do this when the max_cost of all backend were exceeded. In practice, and with changes related to considering multiple backends for pre-operation switches it was realized that this was too restrictive and it would throw a ValueError under certain workloads.
This change allows the calculator to first calculate a backend considering max_cost but, if one is not found, then calculate one disregarding max_cost. A backend should always be returned in this case.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date