TEST-#7686: Fix comparisons in caster tests to check the backend instead of type #7687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jkew
requested review from
a team,
RehanSD,
YarShev,
anmyachev,
dchigarev,
devin-petersohn,
mvashishtha and
vnlitvinov
as code owners
Contributor
sfc-gh-mvashishtha
left a comment
sfc-gh-mvashishtha
left a comment
There was a problem hiding this comment.
We should use == for string comparisons.
modin/tests/pandas/native_df_interoperability/test_compiler_caster.py
Outdated
Show resolved
Hide resolved
modin/tests/pandas/native_df_interoperability/test_compiler_caster.py
Outdated
Show resolved
Hide resolved
modin/tests/pandas/native_df_interoperability/test_compiler_caster.py
Outdated
Show resolved
Hide resolved
modin/tests/pandas/native_df_interoperability/test_compiler_caster.py
Outdated
Show resolved
Hide resolved
modin/tests/pandas/native_df_interoperability/test_compiler_caster.py
Outdated
Show resolved
Hide resolved
…ster.py Co-authored-by: Mahesh Vashishtha <mahesh.vashishtha@snowflake.com>
…ster.py Co-authored-by: Mahesh Vashishtha <mahesh.vashishtha@snowflake.com>
…ster.py Co-authored-by: Mahesh Vashishtha <mahesh.vashishtha@snowflake.com>
…ster.py Co-authored-by: Mahesh Vashishtha <mahesh.vashishtha@snowflake.com>
…ster.py Co-authored-by: Mahesh Vashishtha <mahesh.vashishtha@snowflake.com>
sfc-gh-mvashishtha
approved these changes
Oct 1, 2025
sfc-gh-mvashishtha
added a commit
that referenced
this pull request
Oct 2, 2025
…ead of type (#7687) Originally the tests in `test_compiler_caster.py` only tested against query compilers; so checking that a cast occurred correctly was performed with an assert similar to `assert type(qc1) == type(qc2)`. Eventually the changes were lifted up into the DataFrame object so these asserts became invalid although they continued to pass. A recent test, `test_merge_in_place` was added recently where I accidentally used the old pattern. While fixing this I also discovered that `test_information_asymmetry` was also still using the old style. - [x] first commit message and PR title follow format outlined [here](https://modin.readthedocs.io/en/latest/development/contributing.html#commit-message-formatting) > **_NOTE:_** If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title. - [x] passes `flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py` - [x] passes `black --check modin/ asv_bench/benchmarks scripts/doc_checker.py` - [x] signed commit with `git commit -s` <!-- you can amend your commit with a signature via `git commit -amend -s` --> - [x] Resolves #7686 - [x] tests added and passing - [x] module layout described at `docs/development/architecture.rst` is up-to-date <!-- if you have added, renamed or removed files or directories please update the documentation accordingly --> --------- Co-authored-by: Mahesh Vashishtha <mahesh.vashishtha@snowflake.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally the tests in
test_compiler_caster.pyonly tested against query compilers; so checking that a cast occurred correctly was performed with an assert similar toassert type(qc1) == type(qc2). Eventually the changes were lifted up into the DataFrame object so these asserts became invalid although they continued to pass. A recent test,test_merge_in_placewas added recently where I accidentally used the old pattern. While fixing this I also discovered thattest_information_asymmetrywas also still using the old style.flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date