-
Notifications
You must be signed in to change notification settings - Fork 153
Feature: STM32 ADC trigger and offsets api #1275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Feature: STM32 ADC trigger and offsets api #1275
Conversation
Thanks! Could you Squash your commits, rebase on develop and remove the CMake part that's already in the other PR? I can also do it if you want. |
Ur welcome. Let me try it first. I need to practice this. I still want to add API and test it. I just wanted to get the pipeline running to see if I overlooked something. |
dc43c82
to
080c495
Compare
8f47250
to
ef28598
Compare
I need to retest this with the last fixes on my custom stm32g473 board and i may be able to test this on a nucleo-H7a3 board. For other stm32 on which this is relevant i have no hardware available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The CI is finally passing, yay! \o/
ef28598
to
d771a5c
Compare
How is a test for this api supposed to be? Should i write a g4 nucleo example or something in the unittests area? |
d771a5c
to
608f8a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
You can add an example if you like, but I'm also happy to merge it as is. The advantage of adding an example is that breaking API changes will be detected in the CI. The unit tests are not currently executed on hardware (only manually every now and then), so there's less guarantee. |
Problem:
API for setting the conversion triggers and Channel offsets are missing.
Changes
Provide API to set the regular and injected conversion trigger as well as setting offsets for adc chanels.