Skip to content

Feature: STM32 ADC trigger and offsets api #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Tecnologic
Copy link
Contributor

Problem:
API for setting the conversion triggers and Channel offsets are missing.

Changes
Provide API to set the regular and injected conversion trigger as well as setting offsets for adc chanels.

@salkinium
Copy link
Member

Thanks! Could you Squash your commits, rebase on develop and remove the CMake part that's already in the other PR? I can also do it if you want.

@salkinium salkinium requested a review from chris-durand July 6, 2025 11:05
@salkinium salkinium added this to the 2025q3 milestone Jul 6, 2025
@Tecnologic
Copy link
Contributor Author

Ur welcome. Let me try it first. I need to practice this. I still want to add API and test it. I just wanted to get the pipeline running to see if I overlooked something.

@Tecnologic Tecnologic force-pushed the feature/adc_trigger_api branch 3 times, most recently from dc43c82 to 080c495 Compare July 8, 2025 00:07
@Tecnologic Tecnologic force-pushed the feature/adc_trigger_api branch 10 times, most recently from 8f47250 to ef28598 Compare August 5, 2025 09:27
@Tecnologic Tecnologic marked this pull request as ready for review August 5, 2025 10:13
@Tecnologic
Copy link
Contributor Author

I need to retest this with the last fixes on my custom stm32g473 board and i may be able to test this on a nucleo-H7a3 board. For other stm32 on which this is relevant i have no hardware available

Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The CI is finally passing, yay! \o/

@salkinium salkinium added the ci:hal Triggers the exhaustive HAL compile CI jobs label Aug 11, 2025
@Tecnologic Tecnologic force-pushed the feature/adc_trigger_api branch from ef28598 to d771a5c Compare August 13, 2025 11:31
@Tecnologic
Copy link
Contributor Author

How is a test for this api supposed to be? Should i write a g4 nucleo example or something in the unittests area?

@Tecnologic Tecnologic force-pushed the feature/adc_trigger_api branch from d771a5c to 608f8a2 Compare August 15, 2025 07:54
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@salkinium
Copy link
Member

You can add an example if you like, but I'm also happy to merge it as is. The advantage of adding an example is that breaking API changes will be detected in the CI. The unit tests are not currently executed on hardware (only manually every now and then), so there's less guarantee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:hal Triggers the exhaustive HAL compile CI jobs enhancement 🌈
Development

Successfully merging this pull request may close these issues.

2 participants