[io] Better support for logging in fibers#1279
Merged
salkinium merged 3 commits intomodm-io:developfrom Aug 3, 2025
Merged
Conversation
The implementation does not seem to be available for every GCC.
salkinium
force-pushed
the
feat/fiber_logging
branch
5 times, most recently
from
cc13ef9 to
06d10d0
Compare
IOStream is used almost everywhere
salkinium
force-pushed
the
feat/fiber_logging
branch
2 times, most recently
from
31e9248 to
790d31b
Compare
salkinium
force-pushed
the
feat/fiber_logging
branch
from
790d31b to
7d9070d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IOStream would not yield when BlockIfFull behavior was used (the default for all our boards). But yielding when full would create interlaced output from different fibers, so I implemented a mutex that only unlocks on newlines. So all fibers will wait until one entire line has been produced, then yield. So this now only blocks fibers that wait on the logger output, and not all fibers in the system. The change is backward compatible for when not using fibers.
Other changes:
std::scoped_lockis not enabled in the stdlibc++ for GCC14. Dunno why, but couldn't fix it in any way.