Skip to content

Fix PHP 8.4 deprecation warning for implicit nullable type in getBooleanOption #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix PHP 8.4 deprecation warning for implicit nullable type in getBooleanOption #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3deb348
Initial plan
Copilot Jan 15, 2026
def2231
Fix PHP 8.4 deprecation warning for implicit nullable types in getBoo…
Copilot Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions core/components/alpacka/src/Alpacka.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,11 +534,11 @@ public function explode($string, $separator = ',') {
* including strings "false" and "no" which are sometimes set that way by ExtJS.
*
* @param string $name
* @param array $options
* @param bool $default
* @param array|null $options
* @param mixed $default
* @return bool
*/
public function getBooleanOption($name, array $options = null, $default = null) {
public function getBooleanOption($name, ?array $options = null, $default = null) {
$option = $this->getOption($name, $options, $default);
return $this->castValueToBool($option);
}
Expand Down
17 changes: 16 additions & 1 deletion core/components/alpacka/vendor/autoload.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,21 @@

// autoload.php @generated by Composer

require_once __DIR__ . '/composer' . '/autoload_real.php';
if (PHP_VERSION_ID < 50600) {
if (!headers_sent()) {
header('HTTP/1.1 500 Internal Server Error');
}
$err = 'Composer 2.3.0 dropped support for autoloading on PHP <5.6 and you are running '.PHP_VERSION.', please upgrade PHP or use Composer 2.2 LTS via "composer self-update --2.2". Aborting.'.PHP_EOL;
if (!ini_get('display_errors')) {
if (PHP_SAPI === 'cli' || PHP_SAPI === 'phpdbg') {
fwrite(STDERR, $err);
} elseif (!headers_sent()) {
echo $err;
}
}
throw new RuntimeException($err);
}

require_once __DIR__ . '/composer/autoload_real.php';

return ComposerAutoloaderInitd530de204ef18056db76679ad2b19aa5::getLoader();
Loading