-
Notifications
You must be signed in to change notification settings - Fork 370
feat: manage project versions v2 #5049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tdgao
wants to merge
87
commits into
main
Choose a base branch
from
truman/project-versions-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
87 commits
Select commit
Hold shift + click to select a range
40e3607
update add files copy and go to next step on just one file
tdgao 312490b
rename and reorder stages
tdgao c4c2782
add metadata stage and update details stage
tdgao 36a0e88
implement files inside metadata stage
tdgao 59ab802
use regular prettier instead of prettier eslint
tdgao 29bb86c
remove changelog stage config
tdgao 35302a2
save button on details stage
tdgao 4792e04
update edit buttons in versions table
tdgao f90fabc
add collapse environment selector
tdgao ff29b59
implement dependencies list in metadata step
tdgao 4916005
move dependencies into provider
tdgao d35f490
add suggested dependencies to metadata stage
tdgao 66d5ed1
pnpm prepr
tdgao 7087514
fix unused var
tdgao 88ef419
Revert "add collapse environment selector"
tdgao 7f6b854
hide resource pack loader only when its the only loader
tdgao b84f032
fix no dependencies for modpack
tdgao 19a8b20
add breadcrumbs with hide breadcrumb option
tdgao 3ec4859
wider stages
tdgao 7610956
add proper horizonal scroll breadcrumbs
tdgao 316a100
fix titles
tdgao 81dd02d
handle save version in version page
tdgao 47cc131
Merge branch 'main' into truman/project-versions-v2
tdgao 6514d0c
remove box shadow
tdgao 4f4c1c6
add notification provider to storybook
tdgao a9ed630
add drop area for versions to drop file right into page
tdgao a3b062e
fix mobile versions table buttons overflowing
tdgao 2336353
pnpm prepr
tdgao 4db5a57
fix drop file opening modal in wrong stage
tdgao 976b8c6
implement invalid file for dropping files
tdgao 72e41bd
allow horizontal scroll on breadcrumbs
tdgao 8a53fa0
update infer.js as best as possible
tdgao 9bfce8b
add create version button uploading version state
tdgao aab15c0
add extractVersionFromFilename for resource pack and datapack
tdgao f3a8119
allow jars for datapack project
tdgao f500bb9
detect multiple loaders when possible
tdgao add15a2
iris means compatible with optifine too
tdgao dc31cc4
infer environment on loader change as well
tdgao 92a0f40
add tooltip
tdgao d76fbe1
prevent navigate forward when cannot go to next step
tdgao 63f9e3b
larger breadcrumb click targets
tdgao cfb6cba
hide loaders and mc versions stage until files added
tdgao 8ea2aa4
fix max width in header
tdgao 3ba9135
fix add files from metadata step jumping steps
tdgao 63e689c
define width in NewModal instead
tdgao 4a01b56
disable remove dependency in metadata stage
tdgao 797e17a
switch metadata and details buttons positions
tdgao 02916cf
fix remove button spacing
tdgao eb7c0a0
do not allow duplicate suggested dependencies
tdgao 4771252
fix version detection for fabric minecraft version semvar
tdgao 7f8405b
better verion number detection based on filename
tdgao 5d0499f
show resource pack loader but uneditable
tdgao 9f5761c
remove vanilla shader detection
tdgao 50b9e3f
refactor: break up large infer.js into ts and modules
tdgao 115ee58
remove duplicated types
tdgao 8264ad2
add fill missing from file name step
tdgao b77223c
pnpm prepr
tdgao 02f981c
fix neoforge loader parse failing and not adding neoforge loader
tdgao 8ee09a9
add missing pack formats
tdgao 91b8d57
handle new pack format
tdgao 3a426cd
pnpm prepr
tdgao ae8f5ba
add another regex where it is version in anywhere in filename
tdgao 972d77e
only show resource pack or data pack options for filetype on datapack…
tdgao 8bc9f53
add redundant zip folder check
tdgao e1d6b6e
reject RP and DP if has redundant folder
tdgao 1fb4bf6
fix hide stage in breadcrumb
tdgao be119c6
add snapshot group key in case no release version. brings out 26.1 sn…
tdgao b3331f3
pnpm prepr
tdgao 4c65973
open in group if has something selected
tdgao 2728d89
fix resource pack loader uneditable if accidentally selected on diffe…
tdgao 64fcfe6
add new environment tags
tdgao 02df537
add unknown and not applicable environment tags
tdgao 62780d9
pnpm prepr
tdgao 42a524f
Merge branch 'main' into truman/project-versions-v2
tdgao f2a1f5f
use shared constant on labels
tdgao 9394856
use ref for timeout
tdgao bb30309
remove console logs
tdgao cb7e952
Merge branch 'main' into truman/project-versions-v2
tdgao 7d470cf
remove box shadow only for cm-content
tdgao 249eca5
feat: xhr upload + fix wrangler prettierignore
IMB11 ef78012
fix: upload content type fix
IMB11 045c1ea
fix dependencies version width
tdgao d96b03b
fix already added dependencies logic
tdgao 6c9739c
Merge branches 'truman/project-versions-v2' and 'truman/project-versi…
tdgao bfcb17e
add changelog minheight
tdgao fc64b80
set progress percentage on button
tdgao 5792566
add legacy fabric detection logic
tdgao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,7 @@ | |
| **/dist | ||
| **/.output | ||
| **/.data | ||
| **/.wrangler | ||
| src/generated/** | ||
| src/locales/** | ||
| src/public/news/feed | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
apps/frontend/src/components/ui/create-project-version/components/DependenciesList.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| <template> | ||
| <div v-if="addedDependencies.length" class="5 flex flex-col gap-2"> | ||
| <template v-for="(dependency, index) in addedDependencies"> | ||
| <AddedDependencyRow | ||
| v-if="dependency" | ||
| :key="index" | ||
| :project-id="dependency.projectId" | ||
| :name="dependency.name" | ||
| :icon="dependency.icon" | ||
| :dependency-type="dependency.dependencyType" | ||
| :version-name="dependency.versionName" | ||
| :hide-remove="disableRemove" | ||
| @remove="() => removeDependency(index)" | ||
| /> | ||
| </template> | ||
| <span v-if="!addedDependencies.length"> No dependencies added. </span> | ||
| </div> | ||
| </template> | ||
|
|
||
| <script setup lang="ts"> | ||
| import { injectManageVersionContext } from '~/providers/version/manage-version-modal' | ||
|
|
||
| import AddedDependencyRow from './AddedDependencyRow.vue' | ||
|
|
||
| const { disableRemove } = defineProps<{ | ||
| disableRemove?: boolean | ||
| }>() | ||
|
|
||
| const { draftVersion, dependencyProjects, dependencyVersions, projectsFetchLoading } = | ||
| injectManageVersionContext() | ||
|
|
||
| const addedDependencies = computed(() => | ||
| (draftVersion.value.dependencies || []) | ||
| .map((dep) => { | ||
| if (!dep.project_id) return null | ||
|
|
||
| const dependencyProject = dependencyProjects.value[dep.project_id] | ||
| const versionName = dependencyVersions.value[dep.version_id || '']?.name ?? '' | ||
|
|
||
| if (!dependencyProject && projectsFetchLoading.value) return null | ||
|
|
||
| return { | ||
| projectId: dep.project_id, | ||
| name: dependencyProject?.name, | ||
| icon: dependencyProject?.icon_url, | ||
| dependencyType: dep.dependency_type, | ||
| versionName, | ||
| } | ||
| }) | ||
| .filter(Boolean), | ||
| ) | ||
|
|
||
| const removeDependency = (index: number) => { | ||
| if (!draftVersion.value.dependencies) return | ||
| draftVersion.value.dependencies.splice(index, 1) | ||
| } | ||
| </script> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.