This repository was archived by the owner on Aug 28, 2024. It is now read-only.
allow simple arithmetic in slider input field#174
Open
jakobhellermann wants to merge 1 commit intomodrinth:masterfrom
Open
allow simple arithmetic in slider input field#174jakobhellermann wants to merge 1 commit intomodrinth:masterfrom
jakobhellermann wants to merge 1 commit intomodrinth:masterfrom
Conversation
Member
|
I would definitely not use eval, that sounds like a really bad idea. |
Prospector
approved these changes
Dec 29, 2023
Member
Prospector
left a comment
There was a problem hiding this comment.
I think this is a really cool feature though!
|
I think this is nice for when trying to do it in gigs, but don't want to do the math. And it would be nice to have just general gb mb terms in general (ik this isn't in the PR yet) Though, I think the main problem with the idea is discverability |
Member
|
Discoverability isn't really a concern with shortcut features like this, they're things people can use if they learn about them and if they dont, it's no big deal because they can still do the math themselves and type the number in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements a simple form of modrinth/code#720
2023-12-29.00-32-54.mp4
This only allows simple math in the form of
50+2, no multiple operators, parenthesis, or "8gb + 10mb" symbols, but I wanted to open this PR first to check if there's even interest in merging this.ChatGPT suggested this alternative implementation which would implement parenthesis etc. nicely but I don't know if that's worth the use of the dubious
evalfunction.