Skip to content

Root temp working #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zbowling merged 2 commits into from
Jan 31, 2025
Merged

Root temp working #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72efa0b
Update build.yml
zbowling Jan 31, 2025
638dd1e
Update Dockerfile
zbowling Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,8 @@ jobs:
# Test end-to-end magic workflow
docker run --rm ghcr.io/modular/magic:${{ needs.version.outputs.new-version }}-${{ steps.image-variables.outputs.tag }} sh -c "mkdir /app && cd /app && magic init && magic add python && magic run python --version"
# Test magic global binaries are in PATH
docker run --rm ghcr.io/modular/magic:${{ needs.version.outputs.new-version }}-${{ steps.image-variables.outputs.tag }} sh -c "magic global install rsync && rsync --version"
# Todo: fix global path as root
# docker run --rm ghcr.io/modular/magic:${{ needs.version.outputs.new-version }}-${{ steps.image-variables.outputs.tag }} sh -c "magic global install rsync && rsync --version"
- name: Image digest
run: echo ${{ steps.build.outputs.digest }}

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
ARG MAGIC_VERSION=0.6.4
ARG MAGIC_VERSION=0.6.3
ARG BASE_IMAGE=debian:bookworm-slim

FROM --platform=$TARGETPLATFORM ubuntu:24.04 AS builder

Check warning on line 4 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (debian:bookworm-slim)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 4 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (debian:bookworm)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 4 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (debian:bullseye-slim)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 4 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (debian:bullseye)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 4 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ubuntu:plucky)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 4 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ubuntu:oracular)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 4 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ubuntu:noble)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 4 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ubuntu:jammy)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 4 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ubuntu:focal)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 4 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (nvidia/cuda:12.6.3-base-ubuntu24.04)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 4 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (nvidia/cuda:12.6.3-base-ubuntu22.04)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 4 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (nvidia/cuda:12.6.3-base-ubuntu20.04)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 4 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (nvidia/cuda:12.3.1-base-ubuntu22.04)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 4 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (nvidia/cuda:12.3.1-base-ubuntu20.04)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 4 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (nvidia/cuda:12.2.2-base-ubuntu22.04)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 4 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (nvidia/cuda:12.2.2-base-ubuntu20.04)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 4 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (nvidia/cuda:12.1.1-base-ubuntu22.04)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 4 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (nvidia/cuda:12.1.1-base-ubuntu20.04)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/
# need to specify the ARG again to make it available in this stage
ARG MAGIC_VERSION
RUN apt-get update && apt-get install -y curl
Expand All @@ -11,6 +11,6 @@
-o /magic && chmod +x /magic
RUN /magic --version

FROM --platform=$TARGETPLATFORM $BASE_IMAGE

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (debian:bookworm-slim)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (debian:bookworm)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (debian:bullseye-slim)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (debian:bullseye)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ubuntu:plucky)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ubuntu:oracular)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ubuntu:noble)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ubuntu:jammy)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (ubuntu:focal)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (nvidia/cuda:12.6.3-base-ubuntu24.04)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (nvidia/cuda:12.6.3-base-ubuntu22.04)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (nvidia/cuda:12.6.3-base-ubuntu20.04)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (nvidia/cuda:12.3.1-base-ubuntu22.04)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (nvidia/cuda:12.3.1-base-ubuntu20.04)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (nvidia/cuda:12.2.2-base-ubuntu22.04)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (nvidia/cuda:12.2.2-base-ubuntu20.04)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (nvidia/cuda:12.1.1-base-ubuntu22.04)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / build (nvidia/cuda:12.1.1-base-ubuntu20.04)

Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior 

RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior
More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/
COPY --from=builder --chown=root:root --chmod=0555 /magic /usr/local/bin/magic
ENV PATH="/root/.modular/bin:/root/.magic/bin:${PATH}"