Fix JSONDecodeError in remove-incompatible-packages workflow #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package: mojo-toml v0.3.0 A native TOML 1.0 parser for Mojo with zero Python dependencies. Features: - Complete TOML 1.0 syntax support - 96 comprehensive tests ensuring reliability - Nested tables, dotted keys, duplicate detection - Clear error messages with line/column context - Performance: 26μs for simple parses, 2ms for real files Repository: - GitHub: https://github.com/DataBooth/mojo-toml - Release: https://github.com/DataBooth/mojo-toml/releases/tag/v0.3.0 - License: MIT Testing: Package includes test_package.mojo which validates: - Simple key-value parsing - Integer and array parsing - Nested table structures - Dotted key functionality All 96 tests pass in the source repository. Sponsored by DataBooth (https://www.databooth.com.au/posts/mojo)
Add defensive error handling to load_failed_compatibility() to gracefully handle empty or corrupted JSON files instead of crashing with JSONDecodeError. This prevents the remove-incompatible-packages workflow from failing when encountering edge cases with the failed-compatibility JSON files. Changes: - Check for empty file content before parsing JSON - Wrap json.loads() in try-except to catch JSONDecodeError - Log warnings/errors when encountering problematic files - Return empty dict as fallback in all error cases Co-Authored-By: Warp <agent@warp.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
remove-incompatible-packagesworkflow intermittently fails withJSONDecodeError: Expecting value: line 1 column 1 (char 0)when trying to load failed-compatibility JSON files.This happens when the JSON files are empty or corrupted during the workflow run, causing the entire scheduled job to fail.
Solution
Add defensive error handling to
load_failed_compatibility():json.loads()in try-except to catchJSONDecodeErrorTesting
The fix ensures the workflow continues running even when encountering problematic JSON files, allowing the script to complete and potentially fix the issue in subsequent runs.
Impact
Low risk - only adds error handling without changing the happy path logic. The workflow will be more resilient to edge cases.
Co-Authored-By: Warp agent@warp.dev