Skip to content

Commit 5a7f247

Browse files
fix: resolve eslint errors in test files and cypress e2e tests (#3930)
Co-authored-by: Claude <[email protected]>
1 parent 4d6585b commit 5a7f247

File tree

6 files changed

+28
-8
lines changed

6 files changed

+28
-8
lines changed

.changeset/lint-fix-eslint-errors.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"@module-federation/core": patch
3+
---
4+
5+
Fix ESLint errors across codebase
6+
7+
Resolve various ESLint errors in test files, Cypress e2e tests, and Next.js applications to improve code quality and ensure consistent code style throughout the project.

apps/3000-home/.eslintrc.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
{
1212
"files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
1313
"rules": {
14-
"@next/next/no-html-link-for-pages": ["error", "apps/home/pages"]
14+
"@next/next/no-html-link-for-pages": ["error", "apps/3000-home/pages"]
1515
}
1616
},
1717
{
@@ -24,7 +24,9 @@
2424
},
2525
{
2626
"files": ["*.cy.{ts,js,tsx,jsx}", "cypress/**/*.{ts,js,tsx,jsx}"],
27-
"rules": {}
27+
"rules": {
28+
"cypress/no-unnecessary-waiting": "off"
29+
}
2830
}
2931
],
3032
"rules": {

apps/3001-shop/.eslintrc.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
{
1212
"files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
1313
"rules": {
14-
"@next/next/no-html-link-for-pages": ["error", "apps/shop/pages"]
14+
"@next/next/no-html-link-for-pages": ["error", "apps/3001-shop/pages"]
1515
}
1616
},
1717
{
@@ -24,7 +24,9 @@
2424
},
2525
{
2626
"files": ["*.cy.{ts,js,tsx,jsx}", "cypress/**/*.{ts,js,tsx,jsx}"],
27-
"rules": {}
27+
"rules": {
28+
"cypress/no-unnecessary-waiting": "off"
29+
}
2830
}
2931
],
3032
"rules": {

apps/3002-checkout/.eslintrc.json

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,10 @@
1111
{
1212
"files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
1313
"rules": {
14-
"@next/next/no-html-link-for-pages": ["error", "apps/checkout/pages"]
14+
"@next/next/no-html-link-for-pages": [
15+
"error",
16+
"apps/3002-checkout/pages"
17+
]
1518
}
1619
},
1720
{
@@ -24,7 +27,9 @@
2427
},
2528
{
2629
"files": ["*.cy.{ts,js,tsx,jsx}", "cypress/**/*.{ts,js,tsx,jsx}"],
27-
"rules": {}
30+
"rules": {
31+
"cypress/no-unnecessary-waiting": "off"
32+
}
2833
}
2934
],
3035
"rules": {

packages/runtime-core/__tests__/hooks.spec.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,9 @@ describe('hooks', () => {
310310
loadEntry({ remoteInfo }) {
311311
if (remoteInfo.name === '@loader-hooks/app3') {
312312
return {
313-
init() {},
313+
init() {
314+
// Empty implementation for test
315+
},
314316
get(path) {
315317
return () => path;
316318
},

packages/runtime/__tests__/hooks.spec.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,9 @@ describe('hooks', () => {
312312
loadEntry({ remoteInfo }) {
313313
if (remoteInfo.name === '@loader-hooks/app3') {
314314
return {
315-
init() {},
315+
init() {
316+
// Empty implementation for test
317+
},
316318
get(path) {
317319
return () => path;
318320
},

0 commit comments

Comments
 (0)