Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dry-colts-cough.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@module-federation/storybook-addon': patch
---

prefer use `stroybook/internal/node-logger` as logger
18 changes: 17 additions & 1 deletion packages/storybook-addon/src/lib/storybook-addon.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,24 @@ import {
type Configuration,
type WebpackPluginInstance,
} from 'webpack';
import { logger } from '@storybook/node-logger';
import { normalizeStories } from '@storybook/core/common';
import withModuleFederation from '../utils/with-module-federation.js';
import { correctImportPath } from '../utils/correctImportPath.js';

// TODO: Only reserve `storybook/internal/node-logger` in next major release.
// Dynamic import for logger to support multiple Storybook versions
async function getLogger() {
try {
// Try high version first (since Storybook 9)
const mod = await import('storybook/internal/node-logger');
return mod.logger;
} catch {
// Fallback to low version
const mod = await import('@storybook/node-logger');
return mod.logger;
}
}

import type { moduleFederationPlugin } from '@module-federation/sdk';
import type { ModuleFederationConfig } from '@nx/webpack';

Expand All @@ -38,6 +51,9 @@ export const webpack = async (
const { moduleFederationConfig, presets, nxModuleFederationConfig } = options;
const context = webpackContext || process.cwd();

// Get logger instance (supports multiple Storybook versions)
const logger = await getLogger();

// Detect webpack version. More about storybook webpack config https://storybook.js.org/docs/react/addons/writing-presets#webpack
const webpackVersion = await presets.apply('webpackVersion');
logger.info(`=> [MF] Webpack ${webpackVersion} version detected`);
Expand Down