chore(sdk): migrate to rslib bundleless and align runtime-core loading

.changeset/loud-elephants-lie.md

@@ -0,0 +1,7 @@
+---
+'@module-federation/enhanced': patch
+'@module-federation/inject-external-runtime-core-plugin': patch
+'@module-federation/webpack-bundler-runtime': patch
+---
+
+Migrate webpack-bundler-runtime packaging to rslib bundleless outputs and align related enhanced/runtime plugin integration metadata.

.changeset/tall-seals-lie.md

@@ -0,0 +1,6 @@
+---
+'@module-federation/inject-external-runtime-core-plugin': patch
+'@module-federation/runtime-tools': patch
+---
+
+Migrate runtime-tools to rslib bundleless output and align external runtime-core plugin integration for the new build layout.

.changeset/wet-carpets-begin.md

@@ -0,0 +1,6 @@
+---
+'@module-federation/runtime-core': patch
+'@module-federation/sdk': patch
+---
+
+Migrate SDK packaging to rslib bundleless and update runtime-core SDK imports to safely resolve optional `loadScriptNode` exports in Node paths.

.github/workflows/actionlint.yml

@@ -20,9 +20,4 @@ jobs:
         shell: bash
 
       - name: Run actionlint
-        uses: raven-actions/actionlint@v2
-        env:
-          NODE_PATH: ${{ runner.temp }}/node_modules
-        with:
-          matcher: true
-          working-directory: ${{ runner.temp }}
+        run: ./actionlint -color

apps/manifest-demo/webpack-host/webpack.config.js

@@ -144,6 +144,36 @@ module.exports = composePlugins(withNx(), withReact(), (config, context) => {
       p._options.library = undefined;
     }
   });
+
+  // React Refresh (Fast Refresh) injects runtime hooks into every processed JS module.
+  // Our workspace packages ship pre-bundled CJS outputs that contain nested webpack runtimes
+  // (for example `packages/sdk/dist/index.cjs`). When those files are instrumented, the injected
+  // code can crash at runtime with:
+  //   "Cannot set properties of undefined (setting 'runtime')"
+  // This breaks Cypress e2e that load the manifest host (port 3013).
+  //
+  // We don't rely on Fast Refresh for this demo host, so drop both the webpack plugin and the
+  // `react-refresh/babel` transform to keep e2e stable.
+  config.plugins = (config.plugins || []).filter((p) => {
+    const name = p?.constructor?.name;
+    return !name || !name.includes('ReactRefresh');
+  });
+
+  const babelLoader = (config.module?.rules || []).find(
+    (rule) =>
+      rule &&
+      typeof rule !== 'string' &&
+      rule.loader?.toString().includes('babel-loader'),
+  );
+  if (babelLoader && typeof babelLoader !== 'string') {
+    babelLoader.options = babelLoader.options || {};
+    const plugins = babelLoader.options.plugins || [];
+    babelLoader.options.plugins = plugins.filter((plugin) => {
+      const id = Array.isArray(plugin) ? plugin[0] : plugin;
+      return !(typeof id === 'string' && id.includes('react-refresh/babel'));
+    });
+  }
+
   if (config.devServer) {
     config.devServer.client.overlay = false;
     config.devServer.devMiddleware.writeToDisk = true;

packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts

@@ -73,6 +73,7 @@ const RuntimePath = resolveModule(
   [
     '@module-federation/runtime/dist/index.esm.js',
     '@module-federation/runtime',
+    '@module-federation/runtime/dist/index.js',
     '@module-federation/runtime/dist/index.cjs.cjs',
   ],
   {
@@ -397,6 +398,7 @@ class FederationRuntimePlugin {
           [
             '@module-federation/runtime/dist/index.esm.js',
             '@module-federation/runtime',
+            '@module-federation/runtime/dist/index.js',
             '@module-federation/runtime/dist/index.cjs.cjs',
           ],
           {

packages/enhanced/src/lib/sharing/tree-shaking/IndependentSharedPlugin.ts

@@ -246,35 +246,58 @@ export default class IndependentSharedPlugin {
         if (!shareConfig.treeShaking) {
           return;
         }
-        const shareRequests = shareRequestsMap[shareName].requests;
-        await Promise.all(
-          shareRequests.map(async ([request, version]) => {
-            const sharedConfig = sharedOptions.find(
-              ([name]) => name === shareName,
-            )?.[1];
-            const [shareFileName, globalName, sharedVersion] =
-              await this.createIndependentCompiler(parentCompiler, {
-                shareRequestsMap,
-                currentShare: {
-                  shareName,
-                  version,
-                  request,
-                  independentShareFileName: sharedConfig?.treeShaking?.filename,
-                },
-              });
-            if (typeof shareFileName === 'string') {
-              this.buildAssets[shareName] ||= [];
-              this.buildAssets[shareName].push([
-                path.join(
-                  resolveOutputDir(outputDir, shareName),
-                  shareFileName,
-                ),
-                sharedVersion,
-                globalName,
-              ]);
-            }
-          }),
+
+        const shareRequests = shareRequestsMap[shareName]?.requests || [];
+        if (!shareRequests.length) {
+          return;
+        }
+
+        // De-dupe identical (request, version) pairs. Duplicate requests can
+        // happen when a package is both directly imported and also imported by
+        // another shared package.
+        const seen = new Set<string>();
+        const uniqueShareRequests: [string, string][] = [];
+        for (const [request, version] of shareRequests) {
+          const key = `${version}@@${request}`;
+          if (seen.has(key)) continue;
+          seen.add(key);
+          uniqueShareRequests.push([request, version]);
+        }
+
+        // Ensure we don't keep stale outputs for this share across builds.
+        // Each request/version compilation emits into `${version}/...` under this
+        // directory, so we clean once per shareName, and keep per-compiler
+        // `output.clean` disabled to avoid inter-compiler races.
+        const fullShareOutputDir = path.resolve(
+          parentCompiler.outputPath,
+          resolveOutputDir(outputDir, shareName),
         );
+        try {
+          fs.rmSync(fullShareOutputDir, { recursive: true, force: true });
+        } catch {
+          // ignore
+        }
+
+        for (const [request, version] of uniqueShareRequests) {
+          const [shareFileName, globalName, sharedVersion] =
+            await this.createIndependentCompiler(parentCompiler, {
+              shareRequestsMap,
+              currentShare: {
+                shareName,
+                version,
+                request,
+                independentShareFileName: shareConfig?.treeShaking?.filename,
+              },
+            });
+          if (typeof shareFileName === 'string') {
+            this.buildAssets[shareName] ||= [];
+            this.buildAssets[shareName].push([
+              path.join(resolveOutputDir(outputDir, shareName), shareFileName),
+              sharedVersion,
+              globalName,
+            ]);
+          }
+        }
       }),
     );
 
@@ -379,7 +402,11 @@ export default class IndependentSharedPlugin {
       // 输出配置
       output: {
         path: fullOutputDir,
-        clean: true,
+        // For the initial "collector" compilation we want a clean directory.
+        // For per-share compilations, avoid cleaning the whole output directory
+        // on every compiler run to prevent deleting outputs produced by other
+        // (possibly concurrent) share builds.
+        clean: !extraOptions,
         publicPath: parentConfig.output?.publicPath || 'auto',
       },
 

packages/node/src/runtimePlugin.ts

@@ -2,6 +2,10 @@ import type {
   ModuleFederationRuntimePlugin,
   ModuleFederation,
 } from '@module-federation/runtime';
+
+type BeforeInitArgs = Parameters<
+  Parameters<ModuleFederation['hooks']['lifecycle']['beforeInit']['on']>[0]
+>[0];
 type WebpackRequire = {
   (id: string): any;
   u: (chunkId: string) => string;
@@ -377,7 +381,7 @@ export const setupWebpackRequirePatching = (
 export default function (): ModuleFederationRuntimePlugin {
   return {
     name: 'node-federation-plugin',
-    beforeInit(args) {
+    beforeInit(args: BeforeInitArgs) {
       // Patch webpack chunk loading handlers
       (() => {
         // Create the chunk tracking object

packages/runtime-plugins/inject-external-runtime-core-plugin/package.json

@@ -25,6 +25,9 @@
   "main": "./dist/index.cjs.cjs",
   "module": "./dist/index.esm.js",
   "types": "./dist/index.cjs.d.ts",
+  "browser": {
+    "url": false
+  },
   "exports": {
     ".": {
       "types": "./dist/index.cjs.d.ts",

packages/runtime-plugins/inject-external-runtime-core-plugin/src/index.ts

@@ -1,9 +1,6 @@
-import runtimeCoreDefault, * as runtimeCoreNamespace from '@module-federation/runtime-tools/runtime-core';
+import * as runtimeCore from '@module-federation/runtime-tools/dist/runtime-core.js';
 
 import type { ModuleFederationRuntimePlugin } from '@module-federation/runtime-tools/runtime-core';
-const runtimeCore =
-  (runtimeCoreDefault as typeof runtimeCoreNamespace | undefined) ??
-  runtimeCoreNamespace;
 declare global {
   var __VERSION__: string;
   var _FEDERATION_RUNTIME_CORE: typeof runtimeCore;
@@ -18,16 +15,16 @@ function injectExternalRuntimeCorePlugin(): ModuleFederationRuntimePlugin {
     name: 'inject-external-runtime-core-plugin',
     version: __VERSION__,
     beforeInit(args) {
-      const globalRef = (
-        runtimeCore as typeof runtimeCore & {
-          Global?: typeof runtimeCore.Global;
-        }
-      ).Global;
-      if (!globalRef || typeof globalRef !== 'object') {
-        return args;
-      }
       const name = args.options.name;
       const version = __VERSION__;
+
+      // Use the real host global rather than runtimeCore.Global, since Global can be
+      // missing (tree-shaken/re-export-only) or be a sandboxed view in some MF setups.
+      const globalRef = globalThis as typeof globalThis & {
+        _FEDERATION_RUNTIME_CORE?: typeof runtimeCore;
+        _FEDERATION_RUNTIME_CORE_FROM?: { version: string; name: string };
+      };
+
       if (
         globalRef._FEDERATION_RUNTIME_CORE &&
         globalRef._FEDERATION_RUNTIME_CORE_FROM &&

packages/runtime-tools/package.json

@@ -3,9 +3,12 @@
   "version": "2.0.1",
   "type": "module",
   "author": "zhanghang <hanric.zhang@gmail.com>",
-  "main": "./dist/index.cjs.cjs",
-  "module": "./dist/index.esm.js",
+  "main": "./dist/index.cjs",
+  "module": "./dist/index.js",
   "types": "./dist/index.d.ts",
+  "browser": {
+    "url": false
+  },
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -23,41 +26,41 @@
     ".": {
       "import": {
         "types": "./dist/index.d.ts",
-        "default": "./dist/index.esm.js"
+        "default": "./dist/index.js"
       },
       "require": {
         "types": "./dist/index.d.ts",
-        "default": "./dist/index.cjs.cjs"
+        "default": "./dist/index.cjs"
       }
     },
     "./runtime": {
       "import": {
         "types": "./dist/runtime.d.ts",
-        "default": "./dist/runtime.esm.js"
+        "default": "./dist/runtime.js"
       },
       "require": {
         "types": "./dist/runtime.d.ts",
-        "default": "./dist/runtime.cjs.cjs"
+        "default": "./dist/runtime.cjs"
       }
     },
     "./runtime-core": {
       "import": {
         "types": "./dist/runtime-core.d.ts",
-        "default": "./dist/runtime-core.esm.js"
+        "default": "./dist/runtime-core.js"
       },
       "require": {
         "types": "./dist/runtime-core.d.ts",
-        "default": "./dist/runtime-core.cjs.cjs"
+        "default": "./dist/runtime-core.cjs"
       }
     },
     "./webpack-bundler-runtime": {
       "import": {
         "types": "./dist/webpack-bundler-runtime.d.ts",
-        "default": "./dist/webpack-bundler-runtime.esm.js"
+        "default": "./dist/webpack-bundler-runtime.js"
       },
       "require": {
         "types": "./dist/webpack-bundler-runtime.d.ts",
-        "default": "./dist/webpack-bundler-runtime.cjs.cjs"
+        "default": "./dist/webpack-bundler-runtime.cjs"
       }
     },
     "./*": "./*"

packages/runtime-tools/project.json

@@ -6,25 +6,11 @@
   "tags": ["type:pkg"],
   "targets": {
     "build": {
-      "executor": "@nx/rollup:rollup",
+      "executor": "nx:run-commands",
       "outputs": ["{workspaceRoot}/packages/runtime-tools/dist"],
       "options": {
-        "parallel": false,
-        "outputPath": "packages/runtime-tools/dist",
-        "main": "packages/runtime-tools/src/index.ts",
-        "additionalEntryPoints": [
-          "packages/runtime-tools/src/runtime.ts",
-          "packages/runtime-tools/src/webpack-bundler-runtime.ts"
-        ],
-        "tsConfig": "packages/runtime-tools/tsconfig.lib.json",
-        "assets": [],
-        "project": "packages/runtime-tools/package.json",
-        "compiler": "tsc",
-        "rollupConfig": "packages/runtime-tools/rollup.config.cjs",
-        "format": ["cjs", "esm"],
-        "external": ["@module-federation/*"],
-        "generatePackageJson": false,
-        "useLegacyTypescriptPlugin": false
+        "command": "rslib build",
+        "cwd": "packages/runtime-tools"
       },
       "dependsOn": [
         {

packages/runtime-tools/rslib.config.ts

@@ -0,0 +1,49 @@
+import { defineConfig } from '@rslib/core';
+import { pluginPublint } from 'rsbuild-plugin-publint';
+
+export default defineConfig({
+  plugins: [pluginPublint()],
+  lib: [
+    {
+      format: 'esm',
+      syntax: 'es2021',
+      bundle: false,
+      outBase: 'src',
+      dts: {
+        bundle: false,
+        distPath: './dist',
+      },
+    },
+    {
+      format: 'cjs',
+      syntax: 'es2021',
+      bundle: false,
+      outBase: 'src',
+      dts: false,
+    },
+  ],
+  source: {
+    entry: {
+      index: [
+        './src/**/*.{ts,tsx,js,jsx}',
+        '!./src/**/*.spec.*',
+        '!./src/**/*.test.*',
+      ],
+    },
+    tsconfigPath: './tsconfig.lib.json',
+  },
+  output: {
+    target: 'node',
+    minify: false,
+    distPath: {
+      root: './dist',
+    },
+    externals: [/@module-federation\//],
+    copy: [
+      {
+        from: './LICENSE',
+        to: '.',
+      },
+    ],
+  },
+});