-
Notifications
You must be signed in to change notification settings - Fork 3
Feature Proposal: Remote as an Object #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
schirrel
wants to merge
4
commits into
module-federation:main
Choose a base branch
from
schirrel:feat/fix-name-and-add-remote-as-object-async
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7cafb33
fix(enhanced): fixin plugin name
schirrel d08cd03
feat(remoteObject): create handle for remote as an object and default…
schirrel 56dd633
feat(remoteObject): add docs to readme
schirrel 1d35fd1
Merge remote-tracking branch 'origin/main' into feat/fix-name-and-add…
schirrel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| const defaultOnError = () => { | ||
| const module = { | ||
| get: () => () => {}, | ||
| init: () => () => {}, | ||
| }; | ||
| resolve(module); | ||
| }; | ||
|
|
||
| const dynamicRemote = (remote) => { | ||
| return `(resolve) => { | ||
| const script = document.createElement("script"); | ||
| script.src = "${remote.url}"; | ||
| script.onload = () => { | ||
| const module = { | ||
| get: (request) => window["${remote.name}"].get(request), | ||
| init: (arg) => { | ||
| try { | ||
| return window["${remote.name}"].init(arg); | ||
| } catch (e) { | ||
| console.log("Problem loading remote ${remote.name}", e); | ||
| } | ||
| }, | ||
| }; | ||
| resolve(module); | ||
| }; | ||
| script.onerror = ${ | ||
| remote.onError ? remote.onError.toString() : defaultOnError.toString() | ||
| } | ||
| document.head.appendChild(script); | ||
| }`; | ||
| }; | ||
|
|
||
| const handleAsyncRemote = (remote) => { | ||
| return `promise new Promise(${dynamicRemote(remote).toString()})`; | ||
| }; | ||
|
|
||
| const mountFinalRemoteValue = (remote) => { | ||
| if (remote.async) { | ||
| return handleAsyncRemote(remote); | ||
| } else { | ||
| //Any other implementation of remote as an object goes here | ||
| } | ||
|
|
||
| return remote.name + "@" + remote.url; | ||
| }; | ||
|
|
||
| const HandleRemoteObject = (remotes) => { | ||
| const _newRemotes = {}; | ||
| Object.keys(remotes)?.forEach((remoteName) => { | ||
| const remote = remotes[remoteName]; | ||
| _newRemotes[remoteName] = | ||
| typeof remote === "string" ? remote : mountFinalRemoteValue(remote); | ||
| }); | ||
|
|
||
| return _newRemotes; | ||
| }; | ||
|
|
||
| module.exports = HandleRemoteObject; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should use webpack require.l for script loading here. i opened a PR adding webpack runtime requirements to promise based remotes
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should so this instead